Move chrome/browser/web_dev_style/ to tools/ to use from more places

Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui/, components/version_ui/, components/about_ui/ a
while ago to be used on iOS and was previously checked by presubmits but 
is no longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2890513003
Cr-Commit-Position: refs/heads/master@{#472588}
Committed: https://chromium.googlesource.com/chromium/src/+/ccf7fefad401e05a493e59eabf3c99801fe5fd8a

[Dan Beam, 2017-05-17 02:42:11]

Description was changed from

==========
Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui, components/version_ui, components/about_ui a while
ago to be used on iOS and was previously checked by presubmits but is no
longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
==========

to

==========
Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui, components/version_ui, components/about_ui a while
ago to be used on iOS and was previously checked by presubmits but is no
longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-17 02:53:47]

Description was changed from

==========
Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui, components/version_ui, components/about_ui a while
ago to be used on iOS and was previously checked by presubmits but is no
longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui/, components/version_ui/, components/about_ui/ a while
ago to be used on iOS and was previously checked by presubmits but is no
longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-17 02:54:16]

Description was changed from

==========
Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui/, components/version_ui/, components/about_ui/ a while
ago to be used on iOS and was previously checked by presubmits but is no
longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui/, components/version_ui/, components/about_ui/ a
while ago to be used on iOS and was previously checked by presubmits but 
is no longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-17 02:56:46]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2017-05-17 02:56:50]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-05-17 02:57:07]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 02:58:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-05-17 03:37:13]

lgtm

https://codereview.chromium.org/2890513003/diff/40001/tools/web_dev_style/pre...
File tools/web_dev_style/presubmit_support.py (right):

https://codereview.chromium.org/2890513003/diff/40001/tools/web_dev_style/pre...
tools/web_dev_style/presubmit_support.py:14: is_vulcanized = lambda f: not
f.endswith(('vulcanized.html', 'crisper.js'))
I don't think this is necessary any more, right? We no longer check in any
vulcanize output. In that case, you can also get rid of file_filter and just
have

file_filter=is_resource

below

[commit-bot: I haz the power, 2017-05-17 04:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:21:13]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-05-17 17:33:21]

https://codereview.chromium.org/2890513003/diff/40001/tools/web_dev_style/pre...
File tools/web_dev_style/presubmit_support.py (right):

https://codereview.chromium.org/2890513003/diff/40001/tools/web_dev_style/pre...
tools/web_dev_style/presubmit_support.py:14: is_vulcanized = lambda f: not
f.endswith(('vulcanized.html', 'crisper.js'))
On 2017/05/17 03:37:13, tsergeant wrote:
> I don't think this is necessary any more, right? We no longer check in any
> vulcanize output. In that case, you can also get rid of file_filter and just
> have
> 
> file_filter=is_resource
> 
> below

Done. (thanks!)

[Dan Beam, 2017-05-17 17:42:34]

dbeam@chromium.org changed reviewers:
+ thakis@chromium.org

[Dan Beam, 2017-05-17 17:42:35]

+thakis@ for chrome/ and tools/ OWNERS

[Nico, 2017-05-17 20:43:02]

lgtm

[Dan Beam, 2017-05-17 20:45:01]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:46:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:22:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:22:11]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-05-17 22:04:46]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-05-17 22:04:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2890513003/#ps60001
(title: "tsergeant@ review")

[commit-bot: I haz the power, 2017-05-17 22:06:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 22:24:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495058686935340,
"parent_rev": "0d2b07cab5a9dfb8429b42ae5b8ccdfac5d56fd7", "commit_rev":
"ccf7fefad401e05a493e59eabf3c99801fe5fd8a"}

[commit-bot: I haz the power, 2017-05-17 22:24:44]

Description was changed from

==========
Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui/, components/version_ui/, components/about_ui/ a
while ago to be used on iOS and was previously checked by presubmits but 
is no longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move chrome/browser/web_dev_style/ to tools/ to use from more places

There has always been code that should abide by the web development
style guide[1] in ui/webui/ but hasn't been automatedly checked.

Additionally, code from chrome/browser/ was moved to
components/flags_ui/, components/version_ui/, components/about_ui/ a
while ago to be used on iOS and was previously checked by presubmits but 
is no longer.

This CL moves web_dev_style to a more generic location and hopefully
makes it easier to check a whole CL's web resources with a single method
call.

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2890513003
Cr-Commit-Position: refs/heads/master@{#472588}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccf7fefad401e05a493e59eabf3c...
==========

[commit-bot: I haz the power, 2017-05-17 22:24:45]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ccf7fefad401e05a493e59eabf3c...