tools/web_dev_style/resource_checker.py - Issue 2890513003: Move chrome/browser/web_dev_style/ to tools/ to use from more places

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/web_dev_style/resource_checker.py

Issue 2890513003: Move chrome/browser/web_dev_style/ to tools/ to use from more places (Closed)

Patch Set: tsergeant@ review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """	5 """

6 Presubmit for Chromium HTML/CSS/JS resources. See chrome/browser/PRESUBMIT.py.	6 Presubmit for Chromium HTML/CSS/JS resources. See chrome/browser/PRESUBMIT.py.

7 """	7 """

8	8

9 import regex_check	9 import regex_check

10	10

(...skipping 25 matching lines...) Expand all Loading...
36 if error:	36 if error:

37 errors.append(error)	37 errors.append(error)

38	38

39 if errors:	39 if errors:

40 abs_local_path = f.AbsoluteLocalPath()	40 abs_local_path = f.AbsoluteLocalPath()

41 file_indicator = 'Found resources style issues in %s' % abs_local_path	41 file_indicator = 'Found resources style issues in %s' % abs_local_path

42 prompt_msg = file_indicator + '\n\n' + '\n'.join(errors) + '\n'	42 prompt_msg = file_indicator + '\n\n' + '\n'.join(errors) + '\n'

43 results.append(self.output_api.PresubmitPromptWarning(prompt_msg))	43 results.append(self.output_api.PresubmitPromptWarning(prompt_msg))

44	44

45 return results	45 return results

OLD	NEW

« no previous file with comments | « tools/web_dev_style/regex_check.py ('k') | tools/web_dev_style/resource_checker_test.py » ('j') | no next file with comments »