Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: tools/web_dev_style/js_checker.py

Issue 2890513003: Move chrome/browser/web_dev_style/ to tools/ to use from more places (Closed)
Patch Set: tsergeant@ review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/web_dev_style/html_checker_test.py ('k') | tools/web_dev_style/js_checker_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for Chromium JS resources. 5 """Presubmit script for Chromium JS resources.
6 6
7 See chrome/browser/PRESUBMIT.py 7 See chrome/browser/PRESUBMIT.py
8 """ 8 """
9 9
10 import regex_check 10 import regex_check
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 'Found JavaScript style violations in %s:' % 120 'Found JavaScript style violations in %s:' %
121 f.LocalPath()] + error_lines 121 f.LocalPath()] + error_lines
122 results.append(self.output_api.PresubmitError('\n'.join(error_lines))) 122 results.append(self.output_api.PresubmitError('\n'.join(error_lines)))
123 123
124 if results: 124 if results:
125 results.append(self.output_api.PresubmitNotifyResult( 125 results.append(self.output_api.PresubmitNotifyResult(
126 'See the JavaScript style guide at ' 126 'See the JavaScript style guide at '
127 'https://chromium.googlesource.com/chromium/src/+/master/styleguide/we b/web.md#JavaScript')) 127 'https://chromium.googlesource.com/chromium/src/+/master/styleguide/we b/web.md#JavaScript'))
128 128
129 return results 129 return results
OLDNEW
« no previous file with comments | « tools/web_dev_style/html_checker_test.py ('k') | tools/web_dev_style/js_checker_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698