tools/web_dev_style/css_checker.py - Issue 2890513003: Move chrome/browser/web_dev_style/ to tools/ to use from more places

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/web_dev_style/css_checker.py

Issue 2890513003: Move chrome/browser/web_dev_style/ to tools/ to use from more places (Closed)

Patch Set: tsergeant@ review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/web_dev_style/__init__.py ('k') | tools/web_dev_style/css_checker_test.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2012 The Chromium Authors. All rights reserved.	1 # Copyright 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for Chromium WebUI resources.	5 """Presubmit script for Chromium WebUI resources.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into depot_tools, and see	8 for more details about the presubmit API built into depot_tools, and see

9 https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md	9 https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md

10 for the rules we're checking against here.	10 for the rules we're checking against here.

(...skipping 412 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
423 error += check['after'](line)	423 error += check['after'](line)

424 check_errors.append(error)	424 check_errors.append(error)

425 if len(check_errors) > 0:	425 if len(check_errors) > 0:

426 file_errors.append('- %s\n%s' %	426 file_errors.append('- %s\n%s' %

427 (check['desc'], '\n'.join(check_errors)))	427 (check['desc'], '\n'.join(check_errors)))

428 if file_errors:	428 if file_errors:

429 results.append(self.output_api.PresubmitPromptWarning(	429 results.append(self.output_api.PresubmitPromptWarning(

430 '%s:\n%s' % (f[0], '\n\n'.join(file_errors))))	430 '%s:\n%s' % (f[0], '\n\n'.join(file_errors))))

431	431

432 return results	432 return results

OLD	NEW