Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4261)

Unified Diff: chrome/browser/web_dev_style/resource_checker.py

Issue 2890513003: Move chrome/browser/web_dev_style/ to tools/ to use from more places (Closed)
Patch Set: tsergeant@ review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_dev_style/regex_check.py ('k') | chrome/browser/web_dev_style/resource_checker_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_dev_style/resource_checker.py
diff --git a/chrome/browser/web_dev_style/resource_checker.py b/chrome/browser/web_dev_style/resource_checker.py
deleted file mode 100644
index 5b07c3698e5b669cdca2a3d88223072763f8f9c1..0000000000000000000000000000000000000000
--- a/chrome/browser/web_dev_style/resource_checker.py
+++ /dev/null
@@ -1,45 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""
-Presubmit for Chromium HTML/CSS/JS resources. See chrome/browser/PRESUBMIT.py.
-"""
-
-import regex_check
-
-
-class ResourceChecker(object):
- def __init__(self, input_api, output_api, file_filter=None):
- self.input_api = input_api
- self.output_api = output_api
- self.file_filter = file_filter
-
- def IncludeCheck(self, line_number, line):
- return regex_check.RegexCheck(self.input_api.re, line_number, line,
- "(</include>|<include.*/>)", "Closing <include> tags is unnecessary.")
-
- def RunChecks(self):
- """Check for violations of the Chromium web development style guide. See
- https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md
- """
- results = []
-
- affected_files = self.input_api.change.AffectedFiles(
- file_filter=self.file_filter, include_deletes=False)
-
- for f in affected_files:
- errors = []
-
- for line_number, line in enumerate(f.NewContents(), start=1):
- error = self.IncludeCheck(line_number, line)
- if error:
- errors.append(error)
-
- if errors:
- abs_local_path = f.AbsoluteLocalPath()
- file_indicator = 'Found resources style issues in %s' % abs_local_path
- prompt_msg = file_indicator + '\n\n' + '\n'.join(errors) + '\n'
- results.append(self.output_api.PresubmitPromptWarning(prompt_msg))
-
- return results
« no previous file with comments | « chrome/browser/web_dev_style/regex_check.py ('k') | chrome/browser/web_dev_style/resource_checker_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698