Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 2888993002: Do glFinish before sending snapshot latency info to browser (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by jbauman
Modified:
1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do glFinish before sending snapshot latency info to browser On some GPU bots the swap was completing long before the contents got on screen, so PrintWindow didn't get the correct window contents and some tests were flaky. Triggering a glFinish before sending the latency info for a snapshot request to the browser should be enough to ensure DWM executes the Present before the snapshot is executed. BUG=670098 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2888993002 Cr-Commit-Position: refs/heads/master@{#472749} Committed: https://chromium.googlesource.com/chromium/src/+/5cfb0199ae5af577ca239feccd2d3c3f976ddac6

Patch Set 1 #

Total comments: 2

Patch Set 2 : add current tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M gpu/ipc/service/child_window_surface_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/child_window_surface_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 2 chunks +8 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 18 (11 generated)
jbauman
1 month, 1 week ago (2017-05-18 00:14:02 UTC) #6
Ken Russell (switch to Gerrit)
Awesome work tracking this down John! Is it confirmed that this has (to some degree ...
1 month, 1 week ago (2017-05-18 01:02:11 UTC) #7
jbauman
On 2017/05/18 01:02:11, Ken Russell wrote: > Awesome work tracking this down John! > > ...
1 month, 1 week ago (2017-05-18 01:28:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888993002/20001
1 month, 1 week ago (2017-05-18 01:28:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448236)
1 month ago (2017-05-18 07:06:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888993002/20001
1 month ago (2017-05-18 07:08:53 UTC) #15
commit-bot: I haz the power
1 month ago (2017-05-18 09:14:00 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5cfb0199ae5af577ca239feccd2d...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318