Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2886393003: DevTools: Use badges to render products in timeline details. (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use badges to render products in timeline details. BUG=718655 Review-Url: https://codereview.chromium.org/2886393003 Cr-Commit-Position: refs/heads/master@{#473429} Committed: https://chromium.googlesource.com/chromium/src/+/ca4cad869953b9ea4a2fa194a132526b2520e36b

Patch Set 1 #

Total comments: 10

Patch Set 2 : addressing comments #

Total comments: 2

Patch Set 3 : 4 landing #

Patch Set 4 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -167 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt View 1 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt View 1 2 3 1 chunk +62 lines, -62 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html View 1 1 chunk +24 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js View 1 2 4 chunks +34 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/product_registry/badge.css View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js View 1 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js View 1 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 5 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
alph
3 years, 7 months ago (2017-05-18 19:44:14 UTC) #2
pfeldman
https://codereview.chromium.org/2886393003/diff/1/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js File third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js (right): https://codereview.chromium.org/2886393003/diff/1/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js#newcode44 third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js:44: badgeElement.classList.toggle('hide-badge-title', !showName); 'hide' https://codereview.chromium.org/2886393003/diff/1/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js#newcode78 third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js:78: async _renderBadge(element) { I ...
3 years, 7 months ago (2017-05-18 20:18:34 UTC) #3
alph
ptal https://codereview.chromium.org/2886393003/diff/1/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js File third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js (right): https://codereview.chromium.org/2886393003/diff/1/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js#newcode44 third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js:44: badgeElement.classList.toggle('hide-badge-title', !showName); On 2017/05/18 20:18:33, pfeldman wrote: > ...
3 years, 7 months ago (2017-05-18 22:56:03 UTC) #4
pfeldman
lgtm https://codereview.chromium.org/2886393003/diff/20001/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js File third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js (right): https://codereview.chromium.org/2886393003/diff/20001/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js#newcode82 third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js:82: badgeElement.parentNodeOrShadowHost().parentNodeOrShadowHost().classList.remove('hidden'); extract method? https://codereview.chromium.org/2886393003/diff/20001/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js#newcode111 third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js:111: if (enabled) don't!
3 years, 7 months ago (2017-05-18 23:50:36 UTC) #5
alph
all done
3 years, 7 months ago (2017-05-19 00:01:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886393003/40001
3 years, 7 months ago (2017-05-19 00:05:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/430100)
3 years, 7 months ago (2017-05-19 00:47:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886393003/60001
3 years, 7 months ago (2017-05-19 22:17:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298748)
3 years, 7 months ago (2017-05-19 23:40:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886393003/60001
3 years, 7 months ago (2017-05-19 23:54:52 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298854)
3 years, 7 months ago (2017-05-20 03:09:04 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886393003/60001
3 years, 7 months ago (2017-05-20 08:48:40 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 09:32:20 UTC) #25
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ca4cad869953b9ea4a2fa194a132...

Powered by Google App Engine
This is Rietveld 408576698