Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

Issue 2886393003: DevTools: Use badges to render products in timeline details. (Closed)
Patch Set: rebaseline Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
index 52742a12d7775717c7f5fbd30acfb34bb2f33cad..b04fdc89e21bb35fa2aadcaa17a21118f2a294c5 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
@@ -15,6 +15,7 @@ Timeline.TimelineDetailsView = class extends UI.VBox {
this.element.classList.add('timeline-details');
this._detailsLinkifier = new Components.Linkifier();
+ this._badgePool = new ProductRegistry.BadgePool();
this._tabbedPane = new UI.TabbedPane();
this._tabbedPane.show(this.element);
@@ -112,13 +113,14 @@ Timeline.TimelineDetailsView = class extends UI.VBox {
*/
setSelection(selection) {
this._detailsLinkifier.reset();
+ this._badgePool.reset();
this._selection = selection;
switch (this._selection.type()) {
case Timeline.TimelineSelection.Type.TraceEvent:
var event = /** @type {!SDK.TracingModel.Event} */ (this._selection.object());
- Timeline.TimelineUIUtils.buildTraceEventDetails(
- event, this._model.timelineModel(), this._detailsLinkifier, true)
- .then(fragment => this._appendDetailsTabsForTraceEventAndShowDetails(event, fragment));
+ Timeline.TimelineUIUtils
+ .buildTraceEventDetails(event, this._model.timelineModel(), this._detailsLinkifier, this._badgePool, true)
+ .then(fragment => this._appendDetailsTabsForTraceEventAndShowDetails(event, fragment));
break;
case Timeline.TimelineSelection.Type.Frame:
var frame = /** @type {!TimelineModel.TimelineFrame} */ (this._selection.object());
@@ -134,7 +136,7 @@ Timeline.TimelineDetailsView = class extends UI.VBox {
case Timeline.TimelineSelection.Type.NetworkRequest:
var request = /** @type {!TimelineModel.TimelineModel.NetworkRequest} */ (this._selection.object());
Timeline.TimelineUIUtils
- .buildNetworkRequestDetails(request, this._model.timelineModel(), this._detailsLinkifier)
+ .buildNetworkRequestDetails(request, this._model.timelineModel(), this._detailsLinkifier, this._badgePool)
.then(this._setContent.bind(this));
break;
case Timeline.TimelineSelection.Type.Range:

Powered by Google App Engine
This is Rietveld 408576698