Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html

Issue 2886393003: DevTools: Use badges to render products in timeline details. (Closed)
Patch Set: rebaseline Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html
index 42de865238da1da36a1d0f83ec1394f49a4fe2c8..1127629aa03a652b32d5d98b93a0439cd6cdcc77 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html
@@ -18,36 +18,34 @@ function performActions()
return Promise.all([imagePromise, scriptPromise]);
}
-function test()
+async function test()
{
- InspectorTest.invokeAsyncWithTimeline("performActions", finish);
+ await new Promise(fulfill => InspectorTest.invokeAsyncWithTimeline("performActions", fulfill));
- function finish()
+ var model = InspectorTest.timelineModel();
+ var linkifier = new Components.Linkifier();
+ var badgePool = new ProductRegistry.BadgePool();
+
+ for (var request of model.networkRequests()) {
+ var element = await Timeline.TimelineUIUtils.buildNetworkRequestDetails(request, model, linkifier, badgePool);
+ printElement(element);
+ }
+ InspectorTest.completeTest();
+
+ function printElement(element)
{
- var model = InspectorTest.timelineModel();
- var linkifier = new Components.Linkifier();
- function printRequestDetails(request)
- {
- return Timeline.TimelineUIUtils.buildNetworkRequestDetails(request, model, linkifier).then(printElement);
- }
- function printElement(element)
- {
- var rows = element.querySelectorAll(".timeline-details-view-row");
- for (var i = 0; i < rows.length; ++i) {
- var title = rows[i].firstChild.firstChild.textContent;
- var value = rows[i].lastChild.firstChild;
- if (value.children && value.children.length)
- value = Array.from(value.children, element => element.textContent).slice(1).join('');
- else
- value = value.textContent;
- if (title === "Duration" || title === "Mime Type")
- value = typeof value;
- if (/^file:\/\//.test(value))
- value = /[^/]*$/.exec(value)[0];
- InspectorTest.addResult(title + ": " + value);
- }
+ var rows = element.querySelectorAll(".timeline-details-view-row");
+ for (var i = 0; i < rows.length; ++i) {
+ var title = InspectorTest.deepTextContent(rows[i].firstChild);
+ var value = InspectorTest.deepTextContent(rows[i].lastChild);
+ if (title === "Duration" || title === "Mime Type")
+ value = typeof value;
+ if (/^file:\/\//.test(value))
+ value = /[^/]*$/.exec(value)[0];
+ if (!title && !value)
+ continue;
+ InspectorTest.addResult(title + ": " + value);
}
- Promise.all(model.networkRequests().map(printRequestDetails)).then(InspectorTest.completeTest);
}
}

Powered by Google App Engine
This is Rietveld 408576698