Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html

Issue 2886393003: DevTools: Use badges to render products in timeline details. (Closed)
Patch Set: rebaseline Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html
index e38788ce72a360702ce73d3d07aae94359ada5ef..3d1720bbf6fdb8f0a43cacb80d3dc6a2e064a173 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html
@@ -64,12 +64,17 @@ async function test()
}
}];
+ var badgeRendered = Promise.resolve();
+ InspectorTest.addSniffer(ProductRegistry.BadgePool.prototype, "_renderBadge", (arg, result) => badgeRendered = result, true);
+ Common.settings.moduleSetting('product_registry.badges-visible').set(true);
var model = InspectorTest.createPerformanceModelWithEvents(rawTraceEvents).timelineModel();
var linkifier = new Components.Linkifier();
+ var badgePool = new ProductRegistry.BadgePool();
for (var event of model.mainThreadEvents()) {
- var node = await Timeline.TimelineUIUtils.buildTraceEventDetails(event, model, linkifier);
+ var node = await Timeline.TimelineUIUtils.buildTraceEventDetails(event, model, linkifier, badgePool);
+ await badgeRendered;
for (var child of node.querySelectorAll(".timeline-details-view-row"))
- InspectorTest.addResult(`${child.firstChild.innerText}: ${child.lastChild.innerText}`);
+ InspectorTest.addResult(InspectorTest.deepTextContent(child.firstChild) + ": " + InspectorTest.deepTextContent(child.lastChild));
}
InspectorTest.completeTest();
}

Powered by Google App Engine
This is Rietveld 408576698