Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js

Issue 2886393003: DevTools: Use badges to render products in timeline details. (Closed)
Patch Set: rebaseline Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
index 85825b1c2a5fc4fdc810ddbadd5b55c5605da328..18d60badc0583a756eef9cbee75d0e79c57c7977 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
@@ -17,6 +17,7 @@ Timeline.EventsTimelineTreeView = class extends Timeline.TimelineTreeView {
Timeline.EventsTimelineTreeView.Filters.Events.FilterChanged, this._onFilterChanged, this);
this.init(filters);
this._delegate = delegate;
+ this._badgePool = new ProductRegistry.BadgePool();
this._filters.push.apply(this._filters, this._filtersControl.filters());
this._dataGrid.markColumnAsSortedBy('startTime', DataGrid.DataGrid.Order.Ascending);
this._splitWidget.showBoth();
@@ -27,6 +28,7 @@ Timeline.EventsTimelineTreeView = class extends Timeline.TimelineTreeView {
* @param {!Timeline.TimelineSelection} selection
*/
updateContents(selection) {
+ this._badgePool.reset();
super.updateContents(selection);
if (selection.type() === Timeline.TimelineSelection.Type.TraceEvent) {
var event = /** @type {!SDK.TracingModel.Event} */ (selection.object());
@@ -113,8 +115,9 @@ Timeline.EventsTimelineTreeView = class extends Timeline.TimelineTreeView {
var traceEvent = node.event;
if (!traceEvent)
return false;
- Timeline.TimelineUIUtils.buildTraceEventDetails(traceEvent, this.model().timelineModel(), this._linkifier, false)
- .then(fragment => this._detailsView.element.appendChild(fragment));
+ Timeline.TimelineUIUtils
+ .buildTraceEventDetails(traceEvent, this.model().timelineModel(), this._linkifier, this._badgePool, false)
+ .then(fragment => this._detailsView.element.appendChild(fragment));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698