Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2886083002: MD Settings: Use FireWebUIListener() helper wherever possible. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-downloads_chromium.org, David Trainor- moved to gerrit, michaelpg+watch-md-settings_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Use FireWebUIListener() helper wherever possible. BUG=None Review-Url: https://codereview.chromium.org/2886083002 Cr-Commit-Position: refs/heads/master@{#473357} Committed: https://chromium.googlesource.com/chromium/src/+/98ac5521519151b6cbcd4f501bf640f92e3a74e4

Patch Set 1 #

Patch Set 2 : resolve conflicts #

Total comments: 2

Patch Set 3 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -158 lines) Patch
M chrome/browser/ui/webui/settings/about_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/certificates_handler.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/android_apps_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc View 5 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/date_time_handler.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc View 1 9 chunks +14 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/downloads_handler.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/metrics_reporting_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 5 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/settings/profile_info_handler.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/protocol_handlers_handler.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/settings/safe_browsing_handler.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_default_browser_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_import_data_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
dpapad
3 years, 7 months ago (2017-05-17 17:28:04 UTC) #10
Dan Beam
rs lgtm
3 years, 7 months ago (2017-05-19 01:07:00 UTC) #11
dpapad
https://codereview.chromium.org/2886083002/diff/20001/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc File chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc (right): https://codereview.chromium.org/2886083002/diff/20001/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc#newcode111 chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc:111: FireWebUIListener("on.TreeItemAdded", args); Whoops. Something wrong with my regex capturing. ...
3 years, 7 months ago (2017-05-19 19:39:43 UTC) #12
dpapad
https://codereview.chromium.org/2886083002/diff/20001/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc File chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc (right): https://codereview.chromium.org/2886083002/diff/20001/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc#newcode111 chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc:111: FireWebUIListener("on.TreeItemAdded", args); On 2017/05/19 at 19:39:43, dpapad wrote: > ...
3 years, 7 months ago (2017-05-19 20:35:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886083002/40001
3 years, 7 months ago (2017-05-19 20:37:38 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 22:17:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/98ac5521519151b6cbcd4f501bf6...

Powered by Google App Engine
This is Rietveld 408576698