chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc - Issue 2886083002: MD Settings: Use FireWebUIListener() helper wherever possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

Issue 2886083002: MD Settings: Use FireWebUIListener() helper wherever possible. (Closed)

Patch Set: Fixed typo Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

diff --git a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc b/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

index 56093d1f977c84af5611bdc270324eb99f4cfeab..17987af0a560e56aa162fa0132c3f25c3f44f6dc 100644

--- a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

+++ b/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

@@ -139,9 +139,8 @@ void MediaDevicesSelectionHandler::UpdateDevicesMenu(

base::Value default_value(default_id);

base::Value type_value(device_type);

- CallJavascriptFunction("cr.webUIListenerCallback",

- base::Value("updateDevicesMenu"), type_value,

- device_list, default_value);

+ FireWebUIListener("updateDevicesMenu", type_value, device_list,

+ default_value);

}

std::string MediaDevicesSelectionHandler::GetDeviceDisplayName(