Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: chrome/browser/ui/webui/settings/people_handler.cc

Issue 2886083002: MD Settings: Use FireWebUIListener() helper wherever possible. (Closed)
Patch Set: Fixed typo Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/people_handler.cc
diff --git a/chrome/browser/ui/webui/settings/people_handler.cc b/chrome/browser/ui/webui/settings/people_handler.cc
index 0ff3858657094f5069529c986c7e45f2a6ba1ab8..4c37c95afc8a7893028669f3576aea4cb0a4ef15 100644
--- a/chrome/browser/ui/webui/settings/people_handler.cc
+++ b/chrome/browser/ui/webui/settings/people_handler.cc
@@ -323,9 +323,7 @@ void PeopleHandler::DisplaySpinner() {
base::TimeDelta::FromSeconds(kTimeoutSec), this,
&PeopleHandler::DisplayTimeout);
- CallJavascriptFunction("cr.webUIListenerCallback",
- base::Value("page-status-changed"),
- base::Value(kSpinnerPageStatus));
+ FireWebUIListener("page-status-changed", base::Value(kSpinnerPageStatus));
}
void PeopleHandler::DisplayTimeout() {
@@ -335,9 +333,7 @@ void PeopleHandler::DisplayTimeout() {
// Do not listen to sync startup events.
sync_startup_tracker_.reset();
- CallJavascriptFunction("cr.webUIListenerCallback",
- base::Value("page-status-changed"),
- base::Value(kTimeoutPageStatus));
+ FireWebUIListener("page-status-changed", base::Value(kTimeoutPageStatus));
}
void PeopleHandler::OnDidClosePage(const base::ListValue* args) {
@@ -695,9 +691,7 @@ void PeopleHandler::FocusUI() {
void PeopleHandler::CloseUI() {
CloseSyncSetup();
- CallJavascriptFunction("cr.webUIListenerCallback",
- base::Value("page-status-changed"),
- base::Value(kDonePageStatus));
+ FireWebUIListener("page-status-changed", base::Value(kDonePageStatus));
}
void PeopleHandler::GoogleSigninSucceeded(const std::string& /* account_id */,
@@ -885,8 +879,7 @@ void PeopleHandler::PushSyncPrefs() {
GetStringUTF16(IDS_SYNC_FULL_ENCRYPTION_BODY_CUSTOM));
}
- CallJavascriptFunction("cr.webUIListenerCallback",
- base::Value("sync-prefs-changed"), args);
+ FireWebUIListener("sync-prefs-changed", args);
}
LoginUIService* PeopleHandler::GetLoginUIService() const {
@@ -894,9 +887,7 @@ LoginUIService* PeopleHandler::GetLoginUIService() const {
}
void PeopleHandler::UpdateSyncStatus() {
- CallJavascriptFunction("cr.webUIListenerCallback",
- base::Value("sync-status-changed"),
- *GetSyncStatusDictionary());
+ FireWebUIListener("sync-status-changed", *GetSyncStatusDictionary());
}
void PeopleHandler::MarkFirstSetupComplete() {

Powered by Google App Engine
This is Rietveld 408576698