Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/browser/ui/webui/settings/about_handler.cc

Issue 2886083002: MD Settings: Use FireWebUIListener() helper wherever possible. (Closed)
Patch Set: Fixed typo Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/certificates_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/about_handler.h" 5 #include "chrome/browser/ui/webui/settings/about_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 base::string16 types_msg = GetAllowedConnectionTypesMessage(); 606 base::string16 types_msg = GetAllowedConnectionTypesMessage();
607 if (!types_msg.empty()) 607 if (!types_msg.empty())
608 event->SetString("connectionTypes", types_msg); 608 event->SetString("connectionTypes", types_msg);
609 else 609 else
610 event->Set("connectionTypes", base::MakeUnique<base::Value>()); 610 event->Set("connectionTypes", base::MakeUnique<base::Value>());
611 } else { 611 } else {
612 event->Set("connectionTypes", base::MakeUnique<base::Value>()); 612 event->Set("connectionTypes", base::MakeUnique<base::Value>());
613 } 613 }
614 #endif // defined(OS_CHROMEOS) 614 #endif // defined(OS_CHROMEOS)
615 615
616 CallJavascriptFunction("cr.webUIListenerCallback", 616 FireWebUIListener("update-status-changed", *event);
617 base::Value("update-status-changed"), *event);
618 } 617 }
619 618
620 #if defined(OS_MACOSX) 619 #if defined(OS_MACOSX)
621 void AboutHandler::SetPromotionState(VersionUpdater::PromotionState state) { 620 void AboutHandler::SetPromotionState(VersionUpdater::PromotionState state) {
622 // Worth noting: PROMOTE_DISABLED indicates that promotion is possible, 621 // Worth noting: PROMOTE_DISABLED indicates that promotion is possible,
623 // there's just something else going on right now (e.g. checking for update). 622 // there's just something else going on right now (e.g. checking for update).
624 bool hidden = state == VersionUpdater::PROMOTE_HIDDEN; 623 bool hidden = state == VersionUpdater::PROMOTE_HIDDEN;
625 bool disabled = state == VersionUpdater::PROMOTE_HIDDEN || 624 bool disabled = state == VersionUpdater::PROMOTE_HIDDEN ||
626 state == VersionUpdater::PROMOTE_DISABLED || 625 state == VersionUpdater::PROMOTE_DISABLED ||
627 state == VersionUpdater::PROMOTED; 626 state == VersionUpdater::PROMOTED;
628 bool actionable = state == VersionUpdater::PROMOTE_DISABLED || 627 bool actionable = state == VersionUpdater::PROMOTE_DISABLED ||
629 state == VersionUpdater::PROMOTE_ENABLED; 628 state == VersionUpdater::PROMOTE_ENABLED;
630 629
631 base::string16 text = base::string16(); 630 base::string16 text = base::string16();
632 if (actionable) 631 if (actionable)
633 text = l10n_util::GetStringUTF16(IDS_ABOUT_CHROME_AUTOUPDATE_ALL); 632 text = l10n_util::GetStringUTF16(IDS_ABOUT_CHROME_AUTOUPDATE_ALL);
634 else if (state == VersionUpdater::PROMOTED) 633 else if (state == VersionUpdater::PROMOTED)
635 text = l10n_util::GetStringUTF16(IDS_ABOUT_CHROME_AUTOUPDATE_ALL_IS_ON); 634 text = l10n_util::GetStringUTF16(IDS_ABOUT_CHROME_AUTOUPDATE_ALL_IS_ON);
636 635
637 base::DictionaryValue promo_state; 636 base::DictionaryValue promo_state;
638 promo_state.SetBoolean("hidden", hidden); 637 promo_state.SetBoolean("hidden", hidden);
639 promo_state.SetBoolean("disabled", disabled); 638 promo_state.SetBoolean("disabled", disabled);
640 promo_state.SetBoolean("actionable", actionable); 639 promo_state.SetBoolean("actionable", actionable);
641 if (!text.empty()) 640 if (!text.empty())
642 promo_state.SetString("text", text); 641 promo_state.SetString("text", text);
643 642
644 CallJavascriptFunction("cr.webUIListenerCallback", 643 FireWebUIListener("promotion-state-changed", promo_state);
645 base::Value("promotion-state-changed"), promo_state);
646 } 644 }
647 #endif // defined(OS_MACOSX) 645 #endif // defined(OS_MACOSX)
648 646
649 #if defined(OS_CHROMEOS) 647 #if defined(OS_CHROMEOS)
650 void AboutHandler::OnRegulatoryLabelDirFound( 648 void AboutHandler::OnRegulatoryLabelDirFound(
651 std::string callback_id, 649 std::string callback_id,
652 const base::FilePath& label_dir_path) { 650 const base::FilePath& label_dir_path) {
653 if (label_dir_path.empty()) { 651 if (label_dir_path.empty()) {
654 ResolveJavascriptCallback(base::Value(callback_id), base::Value()); 652 ResolveJavascriptCallback(base::Value(callback_id), base::Value());
655 return; 653 return;
(...skipping 19 matching lines...) Expand all
675 label_dir_path.AppendASCII(kRegulatoryLabelImageFilename).MaybeAsASCII(); 673 label_dir_path.AppendASCII(kRegulatoryLabelImageFilename).MaybeAsASCII();
676 std::string url = 674 std::string url =
677 std::string("chrome://") + chrome::kChromeOSAssetHost + "/" + image_path; 675 std::string("chrome://") + chrome::kChromeOSAssetHost + "/" + image_path;
678 regulatory_info->SetString("url", url); 676 regulatory_info->SetString("url", url);
679 677
680 ResolveJavascriptCallback(base::Value(callback_id), *regulatory_info); 678 ResolveJavascriptCallback(base::Value(callback_id), *regulatory_info);
681 } 679 }
682 #endif // defined(OS_CHROMEOS) 680 #endif // defined(OS_CHROMEOS)
683 681
684 } // namespace settings 682 } // namespace settings
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/certificates_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698