chrome/browser/ui/webui/settings/metrics_reporting_handler.cc - Issue 2886083002: MD Settings: Use FireWebUIListener() helper wherever possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/metrics_reporting_handler.cc

Issue 2886083002: MD Settings: Use FireWebUIListener() helper wherever possible. (Closed)

Patch Set: Fixed typo Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/settings/metrics_reporting_handler.cc

diff --git a/chrome/browser/ui/webui/settings/metrics_reporting_handler.cc b/chrome/browser/ui/webui/settings/metrics_reporting_handler.cc

index 06feda9074594d9a515c3045eb181149848b5ce0..29551ad44fd7022865e398e9b88ffa6235eaa939 100644

--- a/chrome/browser/ui/webui/settings/metrics_reporting_handler.cc

+++ b/chrome/browser/ui/webui/settings/metrics_reporting_handler.cc

@@ -96,9 +96,7 @@ void MetricsReportingHandler::OnPrefChanged(const std::string& pref_name) {

}

void MetricsReportingHandler::SendMetricsReportingChange() {

- CallJavascriptFunction("cr.webUIListenerCallback",

- base::Value("metrics-reporting-change"),

- *CreateMetricsReportingDict());

+ FireWebUIListener("metrics-reporting-change", *CreateMetricsReportingDict());

}

} // namespace settings