Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2885253002: [inspector] Extract IsolateData out of TaskRunner (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Extract IsolateData out of TaskRunner This brings clear separation to tasks vs isolate management. BUG=none Review-Url: https://codereview.chromium.org/2885253002 Cr-Commit-Position: refs/heads/master@{#45355} Committed: https://chromium.googlesource.com/v8/v8/+/578150a5f9a34aa405dc877387717bc5855bd0ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -161 lines) Patch
M test/inspector/inspector-impl.h View 3 chunks +6 lines, -4 lines 0 comments Download
M test/inspector/inspector-impl.cc View 7 chunks +33 lines, -34 lines 0 comments Download
M test/inspector/inspector-test.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M test/inspector/task-runner.h View 4 chunks +56 lines, -42 lines 0 comments Download
M test/inspector/task-runner.cc View 6 chunks +67 lines, -73 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
dgozman
Take a look please.
3 years, 7 months ago (2017-05-16 22:29:05 UTC) #4
kozy
lgtm
3 years, 7 months ago (2017-05-16 22:46:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885253002/1
3 years, 7 months ago (2017-05-16 22:47:22 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 23:14:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/578150a5f9a34aa405dc877387717bc5855...

Powered by Google App Engine
This is Rietveld 408576698