Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: test/inspector/inspector-impl.h

Issue 2885253002: [inspector] Extract IsolateData out of TaskRunner (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/inspector/inspector-impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/inspector-impl.h
diff --git a/test/inspector/inspector-impl.h b/test/inspector/inspector-impl.h
index 93ae93996b51d09788cdf21d9750ac5a08020f8e..92e83747f515934e47db7a99769178c76fb40dcb 100644
--- a/test/inspector/inspector-impl.h
+++ b/test/inspector/inspector-impl.h
@@ -28,7 +28,7 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
void scheduleReconnect(v8::base::Semaphore* ready_semaphore);
void scheduleDisconnect(v8::base::Semaphore* ready_semaphore);
void scheduleCreateContextGroup(
- TaskRunner::SetupGlobalTasks setup_global_tasks,
+ IsolateData::SetupGlobalTasks setup_global_tasks,
v8::base::Semaphore* ready_semaphore, int* context_group_id);
static v8_inspector::V8Inspector* InspectorFromContext(
@@ -62,12 +62,14 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
friend class SendMessageToBackendTask;
friend class ConnectTask;
- void connect(v8::Local<v8::Context> context);
+ void connect();
+ void ConnectToContextGroup(int context_group_id,
+ v8_inspector::StringView state);
friend class DisconnectTask;
void disconnect(bool reset_inspector);
friend class CreateContextGroupTask;
int createContextGroup(
- const TaskRunner::SetupGlobalTasks& setup_global_tasks);
+ const IsolateData::SetupGlobalTasks& setup_global_tasks);
std::unique_ptr<v8_inspector::V8Inspector> inspector_;
std::unique_ptr<v8_inspector::V8Inspector::Channel> channel_;
@@ -88,7 +90,7 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
DISALLOW_COPY_AND_ASSIGN(InspectorClientImpl);
};
-class SendMessageToBackendExtension : public TaskRunner::SetupGlobalTask {
+class SendMessageToBackendExtension : public IsolateData::SetupGlobalTask {
public:
void Run(v8::Isolate* isolate, v8::Local<v8::ObjectTemplate> global) override;
« no previous file with comments | « no previous file | test/inspector/inspector-impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698