Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2887013002: [inspector] Move IsolateData to a separate file (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Move IsolateData to a separate file BUG=none Review-Url: https://codereview.chromium.org/2887013002 Cr-Commit-Position: refs/heads/master@{#45356} Committed: https://chromium.googlesource.com/v8/v8/+/fc6cfbfdc16add07ac3727f13f8ac54e386a3b11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -108 lines) Patch
M test/inspector/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M test/inspector/inspector.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A test/inspector/isolate-data.h View 1 chunk +62 lines, -0 lines 0 comments Download
A test/inspector/isolate-data.cc View 1 chunk +79 lines, -0 lines 0 comments Download
M test/inspector/task-runner.h View 1 chunk +1 line, -48 lines 0 comments Download
M test/inspector/task-runner.cc View 2 chunks +0 lines, -60 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dgozman
Take a look please.
3 years, 7 months ago (2017-05-16 23:06:07 UTC) #2
kozy
lgtm
3 years, 7 months ago (2017-05-16 23:14:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887013002/1
3 years, 7 months ago (2017-05-16 23:55:53 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 00:31:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fc6cfbfdc16add07ac3727f13f8ac54e386...

Powered by Google App Engine
This is Rietveld 408576698