[inspector] Extract IsolateData out of TaskRunner

test/inspector/inspector-test.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(_WIN32) && !defined(_WIN64)
 #include <unistd.h>  // NOLINT
 #endif               // !defined(_WIN32) && !defined(_WIN64)
 
 #include <locale.h>
 
@@ skipping 33 matching lines @@
       v8::internal::Vector<uint16_t>::New(str->Length());
   str->Write(buffer.start(), 0, str->Length());
   return buffer;
 }
 
 v8::Local<v8::String> ToV8String(v8::Isolate* isolate, const char* str) {
   return v8::String::NewFromUtf8(isolate, str, v8::NewStringType::kNormal)
       .ToLocalChecked();
 }
 
-class UtilsExtension : public TaskRunner::SetupGlobalTask {
+class UtilsExtension : public IsolateData::SetupGlobalTask {
  public:
   ~UtilsExtension() override = default;
   void Run(v8::Isolate* isolate,
            v8::Local<v8::ObjectTemplate> global) override {
     v8::Local<v8::ObjectTemplate> utils = v8::ObjectTemplate::New(isolate);
     utils->Set(ToV8String(isolate, "print"),
                v8::FunctionTemplate::New(isolate, &UtilsExtension::Print));
     utils->Set(ToV8String(isolate, "quit"),
                v8::FunctionTemplate::New(isolate, &UtilsExtension::Quit));
     utils->Set(ToV8String(isolate, "setlocale"),
@@ skipping 119 matching lines @@
 
   static void Load(const v8::FunctionCallbackInfo<v8::Value>& args) {
     if (args.Length() != 1 || !args[0]->IsString()) {
       fprintf(stderr, "Internal error: load gets one string argument.");
       Exit();
     }
     v8::internal::Vector<const char> chars;
     v8::Isolate* isolate = args.GetIsolate();
     if (ReadFile(isolate, args[0], &chars)) {
       ExecuteStringTask(chars).RunOnTaskRunner(
-          TaskRunner::FromContext(isolate->GetCurrentContext()));
+          IsolateData::FromContext(isolate->GetCurrentContext())
+              ->task_runner());
     }
   }
 
   static void CompileAndRunWithOrigin(
       const v8::FunctionCallbackInfo<v8::Value>& args) {
     if (args.Length() != 5 || !args[0]->IsString() || !args[1]->IsString() ||
         !args[2]->IsInt32() || !args[3]->IsInt32() || !args[4]->IsBoolean()) {
       fprintf(stderr,
               "Internal error: compileAndRunWithOrigin(source, name, line, "
               "column, is_module).");
@@ skipping 105 matching lines @@
     v8::Context::Scope context_scope(context);
 
     v8::Local<v8::Function> function = function_.Get(isolate());
     v8::MaybeLocal<v8::Value> result;
     result = function->Call(context, context->Global(), 0, nullptr);
   }
 
   v8::Global<v8::Function> function_;
 };
 
-class SetTimeoutExtension : public TaskRunner::SetupGlobalTask {
+class SetTimeoutExtension : public IsolateData::SetupGlobalTask {
  public:
   void Run(v8::Isolate* isolate,
            v8::Local<v8::ObjectTemplate> global) override {
     global->Set(
         ToV8String(isolate, "setTimeout"),
         v8::FunctionTemplate::New(isolate, &SetTimeoutExtension::SetTimeout));
   }
 
  private:
   static void SetTimeout(const v8::FunctionCallbackInfo<v8::Value>& args) {
@@ skipping 12 matching lines @@
     if (args[0]->IsFunction()) {
       task.reset(new SetTimeoutTask(isolate,
                                     v8::Local<v8::Function>::Cast(args[0]),
                                     "setTimeout", inspector));
     } else {
       task.reset(new ExecuteStringTask(
           ToVector(args[0].As<v8::String>()), v8::String::Empty(isolate),
           v8::Integer::New(isolate, 0), v8::Integer::New(isolate, 0),
           v8::Boolean::New(isolate, false), "setTimeout", inspector));
     }
-    TaskRunner::FromContext(context)->Append(task.release());
+    IsolateData::FromContext(context)->task_runner()->Append(task.release());
   }
 };
 
 bool StrictAccessCheck(v8::Local<v8::Context> accessing_context,
                        v8::Local<v8::Object> accessed_object,
                        v8::Local<v8::Value> data) {
   CHECK(accessing_context.IsEmpty());
   return accessing_context.IsEmpty();
 }
 
-class InspectorExtension : public TaskRunner::SetupGlobalTask {
+class InspectorExtension : public IsolateData::SetupGlobalTask {
  public:
   ~InspectorExtension() override = default;
   void Run(v8::Isolate* isolate,
            v8::Local<v8::ObjectTemplate> global) override {
     v8::Local<v8::ObjectTemplate> inspector = v8::ObjectTemplate::New(isolate);
     inspector->Set(
         ToV8String(isolate, "attachInspector"),
         v8::FunctionTemplate::New(isolate, &InspectorExtension::Attach));
     inspector->Set(
         ToV8String(isolate, "detachInspector"),
@@ skipping 149 matching lines @@
 };
 
 void UtilsExtension::CreateContextGroup(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   if (args.Length() != 0) {
     fprintf(stderr, "Internal error: createContextGroup().");
     Exit();
   }
   v8::base::Semaphore ready_semaphore(0);
   int context_group_id = 0;
-  TaskRunner::SetupGlobalTasks setup_global;
+  IsolateData::SetupGlobalTasks setup_global;
   setup_global.emplace_back(new SetTimeoutExtension());
   setup_global.emplace_back(new InspectorExtension());
   inspector_client_->scheduleCreateContextGroup(
       std::move(setup_global), &ready_semaphore, &context_group_id);
   ready_semaphore.Wait();
   args.GetReturnValue().Set(
       v8::Int32::New(args.GetIsolate(), context_group_id));
 }
 
 v8::Local<v8::String> ToString(v8::Isolate* isolate,
@@ skipping 57 matching lines @@
   v8::StartupData startup_data = {nullptr, 0};
   for (int i = 1; i < argc; ++i) {
     if (strcmp(argv[i], "--embed") == 0) {
       argv[i++] = nullptr;
       printf("Embedding script '%s'\n", argv[i]);
       startup_data = v8::V8::CreateSnapshotDataBlob(argv[i]);
       argv[i] = nullptr;
     }
   }
 
-  TaskRunner::SetupGlobalTasks backend_extensions;
+  IsolateData::SetupGlobalTasks backend_extensions;
   backend_extensions.emplace_back(new SetTimeoutExtension());
   backend_extensions.emplace_back(new InspectorExtension());
   TaskRunner backend_runner(std::move(backend_extensions), false,
                             &ready_semaphore,
                             startup_data.data ? &startup_data : nullptr);
   ready_semaphore.Wait();
   SendMessageToBackendExtension::set_backend_task_runner(&backend_runner);
   UtilsExtension::set_backend_task_runner(&backend_runner);
 
-  TaskRunner::SetupGlobalTasks frontend_extensions;
+  IsolateData::SetupGlobalTasks frontend_extensions;
   frontend_extensions.emplace_back(new UtilsExtension());
   frontend_extensions.emplace_back(new SendMessageToBackendExtension());
   TaskRunner frontend_runner(std::move(frontend_extensions), true,
                              &ready_semaphore, nullptr);
   ready_semaphore.Wait();
 
   FrontendChannelImpl frontend_channel(&frontend_runner);
   InspectorClientImpl inspector_client(&backend_runner, &frontend_channel,
                                        &ready_semaphore);
   ready_semaphore.Wait();
@@ skipping 16 matching lines @@
     }
     frontend_runner.Append(new ExecuteStringTask(chars));
   }
 
   frontend_runner.Join();
   backend_runner.Join();
 
   delete startup_data.data;
   return 0;
 }