Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 2886903003: [inspector] Pass TaskRunner instead of Context to all tasks (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Pass TaskRunner instead of Context to all tasks This will make it easier to create more connections/context groups. BUG=none Review-Url: https://codereview.chromium.org/2886903003 Cr-Commit-Position: refs/heads/master@{#45352} Committed: https://chromium.googlesource.com/v8/v8/+/a2304802d8d1349bc7ac280a84b2cffa68b883ea

Patch Set 1 #

Patch Set 2 : methods visibility #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -63 lines) Patch
M test/inspector/inspector-impl.cc View 1 5 chunks +13 lines, -19 lines 0 comments Download
M test/inspector/inspector-test.cc View 1 2 chunks +8 lines, -10 lines 0 comments Download
M test/inspector/task-runner.h View 1 3 chunks +20 lines, -10 lines 0 comments Download
M test/inspector/task-runner.cc View 6 chunks +22 lines, -24 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
dgozman
Could you please take a look?
3 years, 7 months ago (2017-05-16 20:02:13 UTC) #2
kozy
lgtm
3 years, 7 months ago (2017-05-16 20:20:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886903003/20001
3 years, 7 months ago (2017-05-16 20:21:09 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 20:38:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a2304802d8d1349bc7ac280a84b2cffa68b...

Powered by Google App Engine
This is Rietveld 408576698