Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2878873002: webkitpy: Rename WebKitFinder to PathFinder (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Rename WebKitFinder to PathFinder BUG=710535 Review-Url: https://codereview.chromium.org/2878873002 Cr-Commit-Position: refs/heads/master@{#471640} Committed: https://chromium.googlesource.com/chromium/src/+/fc3bf0e63c552b01af736044b48f3a44a3e5b8be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -293 lines) Patch
M third_party/WebKit/Tools/Scripts/run-bindings-tests View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/test-webkitpy View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py View 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py View 1 chunk +8 lines, -8 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py View 1 chunk +0 lines, -171 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layout_tests_server.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
qyearsley@, would you review this please?
3 years, 7 months ago (2017-05-12 22:14:39 UTC) #6
qyearsley
LGTM Yay, thanks!
3 years, 7 months ago (2017-05-12 22:24:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878873002/1
3 years, 7 months ago (2017-05-14 21:14:25 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-14 22:31:45 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc3bf0e63c552b01af736044b48f...

Powered by Google App Engine
This is Rietveld 408576698