Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

Issue 2878873002: webkitpy: Rename WebKitFinder to PathFinder (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
index 7920da41ebfe884fb0f8e172bbd1d2001f6d9e7c..591deb084c6e992dd3970b1bccd8e17c6f5806f8 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
@@ -31,9 +31,9 @@ import optparse
import subprocess
import sys
+from webkitpy.common.path_finder import PathFinder
from webkitpy.common.system.executive import Executive
from webkitpy.common.system.filesystem import FileSystem
-from webkitpy.common.webkit_finder import WebKitFinder
_log = logging.getLogger(__name__)
@@ -54,7 +54,7 @@ class Bisector(object):
self.tests = tests
self.expected_failure = tests[-1]
self.is_debug = is_debug
- self.webkit_finder = WebKitFinder(FileSystem())
+ self.path_finder = PathFinder(FileSystem())
def bisect(self):
if self.test_fails_in_isolation():
@@ -145,7 +145,7 @@ class Bisector(object):
def test_fails(self, tests):
extra_args = ['--debug'] if self.is_debug else []
- path_to_run_webkit_tests = self.webkit_finder.path_from_tools_scripts('run-webkit-tests')
+ path_to_run_webkit_tests = self.path_finder.path_from_tools_scripts('run-webkit-tests')
output = self.executive.popen(
[path_to_run_webkit_tests, '--child-processes', '1', '--order', 'none', '--no-retry',
'--no-show-results', '--verbose'] + extra_args + tests, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

Powered by Google App Engine
This is Rietveld 408576698