third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py - Issue 2878873002: webkitpy: Rename WebKitFinder to PathFinder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2878873002: webkitpy: Rename WebKitFinder to PathFinder (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index 5639c14189494d944ca834829a03eb650d656da0..0e6b7aa41fc1e0d8ee2ff92f4e38668437beb49d 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -45,7 +45,7 @@ import time

from webkitpy.common import exit_codes

from webkitpy.common.net.file_uploader import FileUploader

-from webkitpy.common.webkit_finder import WebKitFinder

+from webkitpy.common.path_finder import PathFinder

from webkitpy.layout_tests.controllers.layout_test_finder import LayoutTestFinder

from webkitpy.layout_tests.controllers.layout_test_runner import LayoutTestRunner

from webkitpy.layout_tests.controllers.test_result_writer import TestResultWriter

@@ -91,7 +91,7 @@ class Manager(object):

self._results_directory = self._port.results_directory()

self._finder = LayoutTestFinder(self._port, self._options)

- self._webkit_finder = WebKitFinder(port.host.filesystem)

+ self._path_finder = PathFinder(port.host.filesystem)

self._runner = LayoutTestRunner(self._options, self._port, self._printer, self._results_directory, self._test_is_slow)

def run(self, args):

@@ -542,7 +542,7 @@ class Manager(object):

_log.error("Upload failed: %s", err)

def _copy_results_html_file(self, destination_path):

- base_dir = self._webkit_finder.path_from_layout_tests('fast', 'harness')

+ base_dir = self._path_finder.path_from_layout_tests('fast', 'harness')

results_file = self._filesystem.join(base_dir, 'results.html')

# Note that the results.html template file won't exist when we're using a MockFileSystem during unit tests,

# so make sure it exists before we try to copy it.