third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py - Issue 2878873002: webkitpy: Rename WebKitFinder to PathFinder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

Issue 2878873002: webkitpy: Rename WebKitFinder to PathFinder (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

index 56a2d63e604e0efe567d7b5a30933e8e07b5d7ae..cdbc1e10c5dc56dfc1baf06b9af2d81ae4e56748 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

@@ -32,7 +32,7 @@ import fnmatch

import optparse

import re

-from webkitpy.common.webkit_finder import WebKitFinder

+from webkitpy.common.path_finder import PathFinder

class PortFactory(object):

@@ -168,7 +168,7 @@ def _read_configuration_from_gn(fs, options):

build_directory = getattr(options, 'build_directory', None) or 'out'

target = options.target

- finder = WebKitFinder(fs)

+ finder = PathFinder(fs)

path = fs.join(finder.chromium_base(), build_directory, target, 'args.gn')

if not fs.exists(path):

path = fs.join(finder.chromium_base(), build_directory, target, 'toolchain.ninja')