Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py

Issue 2878873002: webkitpy: Rename WebKitFinder to PathFinder (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py
similarity index 72%
rename from third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py
rename to third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py
index 8ccc92433af427e36bd4272049ca04ab05e5cd99..84e804f725a776faeb6a6a5fe6f05b860fc9afa2 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py
@@ -4,36 +4,36 @@
import unittest
-from webkitpy.common.webkit_finder import WebKitFinder
+from webkitpy.common.path_finder import PathFinder
from webkitpy.common.system.filesystem_mock import MockFileSystem
-class TestWebKitFinder(unittest.TestCase):
+class TestPathFinder(unittest.TestCase):
- # TODO(qyearsley): Add tests for other methods in WebKitFinder.
+ # TODO(qyearsley): Add tests for other methods in PathFinder.
# Including tests for cases when the separator character is backslash.
def test_layout_test_name(self):
- finder = WebKitFinder(MockFileSystem())
+ finder = PathFinder(MockFileSystem())
self.assertEqual(
finder.layout_test_name('third_party/WebKit/LayoutTests/test/name.html'),
'test/name.html')
def test_layout_test_name_not_in_layout_tests_dir(self):
- finder = WebKitFinder(MockFileSystem())
+ finder = PathFinder(MockFileSystem())
self.assertIsNone(finder.layout_test_name('some/other/path/file.html'))
# pylint: disable=protected-access
def test_webkit_base(self):
- finder = WebKitFinder(MockFileSystem())
+ finder = PathFinder(MockFileSystem())
self.assertEqual(finder._webkit_base(), '/mock-checkout/third_party/WebKit')
def test_chromium_base(self):
- finder = WebKitFinder(MockFileSystem())
+ finder = PathFinder(MockFileSystem())
self.assertEqual(finder.chromium_base(), '/mock-checkout')
def test_path_from_chromium_base(self):
- finder = WebKitFinder(MockFileSystem())
+ finder = PathFinder(MockFileSystem())
self.assertEqual(
finder.path_from_chromium_base('foo', 'bar.baz'),
'/mock-checkout/foo/bar.baz')

Powered by Google App Engine
This is Rietveld 408576698