cleanup dart code completion contributors

cleanup dart code completion contributors

Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.

DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/6798cdfcd18f04660e4691fb468311979d29dbac

[danrubel, 2017-05-10 22:12:32]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, pquitslund@google.com

[Brian Wilkerson, 2017-05-10 22:42:44]

brianwilkerson@google.com changed reviewers:
+ maxkim@google.com, mfairhurst@google.com

[Brian Wilkerson, 2017-05-10 22:42:44]

nice! lgtm

Mike and Max: Does this negatively impact the angular plugin?

[pquitslund, 2017-05-10 22:45:19]

SUPER!

[danrubel, 2017-05-11 16:12:42]

Description was changed from

==========
cleanup dart code completion contributors

Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.

DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression
==========

to

==========
cleanup dart code completion contributors

Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.

DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6798cdfcd18f04660e4691fb468311979d29dbac
==========

[danrubel, 2017-05-11 16:12:44]

Committed patchset #2 (id:20001) manually as
6798cdfcd18f04660e4691fb468311979d29dbac (presubmit successful).

[maxkim, 2017-05-11 16:39:30]

On 2017/05/10 22:42:44, Brian Wilkerson wrote:
> nice! lgtm
> 
> Mike and Max: Does this negatively impact the angular plugin?

Sorry for the late response - there's no major impact on our code :) we just
have to clean up our code for the removed overrides.

[danrubel, 2017-05-11 19:40:17]

On 2017/05/11 16:39:30, maxkim wrote:
> On 2017/05/10 22:42:44, Brian Wilkerson wrote:
> > nice! lgtm
> > 
> > Mike and Max: Does this negatively impact the angular plugin?
> 
> Sorry for the late response - there's no major impact on our code :) we just
> have to clean up our code for the removed overrides.

At which point you update your analysis server, here's a PR that you can apply
that should upgrade the API.
https://github.com/dart-lang/angular_analyzer_plugin/tree/code-completion-api...

[danrubel, 2017-05-11 19:47:04]

On 2017/05/11 19:40:17, danrubel wrote:
> On 2017/05/11 16:39:30, maxkim wrote:
> > On 2017/05/10 22:42:44, Brian Wilkerson wrote:
> > > nice! lgtm
> > > 
> > > Mike and Max: Does this negatively impact the angular plugin?
> > 
> > Sorry for the late response - there's no major impact on our code :) we just
> > have to clean up our code for the removed overrides.
> 
> At which point you update your analysis server, here's a PR that you can apply
> that should upgrade the API.
>
https://github.com/dart-lang/angular_analyzer_plugin/tree/code-completion-api...

.... and it appears you've already integrated the change    \o/