Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart

Issue 2873943003: cleanup dart code completion contributors (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart
index 1e87b11804d336594c7d7008ba663491b9f442af..09d0657e9dcf89cb62e5521bfda30a8ecca69051 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart
@@ -23,24 +23,18 @@ class LibraryMemberContributor extends DartCompletionContributor {
Future<List<CompletionSuggestion>> computeSuggestions(
DartCompletionRequest request) async {
// Determine if the target looks like a library prefix
- if (request.dotTarget is! SimpleIdentifier) {
- return EMPTY_LIST;
- }
-
- // Resolve the expression and the containing library
- await request.resolveContainingExpression(request.dotTarget);
-
- // Recompute the target since resolution may have changed it
Expression targetId = request.dotTarget;
if (targetId is SimpleIdentifier && !request.target.isCascade) {
Element elem = targetId.bestElement;
if (elem is PrefixElement && !elem.isSynthetic) {
- List<ImportElement> imports = await request.resolveImports();
LibraryElement containingLibrary = request.libraryElement;
// Gracefully degrade if the library or directives
// could not be determined (e.g. detached part file or source change)
- if (containingLibrary != null && imports != null) {
- return _buildSuggestions(request, elem, containingLibrary, imports);
+ if (containingLibrary != null) {
+ List<ImportElement> imports = containingLibrary.imports;
+ if (imports != null) {
+ return _buildSuggestions(request, elem, containingLibrary, imports);
+ }
}
}
}

Powered by Google App Engine
This is Rietveld 408576698