pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart - Issue 2873943003: cleanup dart code completion contributors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

Issue 2873943003: cleanup dart code completion contributors (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

index 028c55dcb64726eb71bdde4f7a91d694bf01d53f..aeda6b8ed00d6f307e133d5831a0d722174f6b2d 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

@@ -26,9 +26,6 @@ class CombinatorContributor extends DartCompletionContributor {

return EMPTY_LIST;

}

- // TODO(scheglov) Not sure why we need this now.

- await request.resolveImports();

// Build list of suggestions

var directive = node.getAncestor((parent) => parent is NamespaceDirective);

if (directive is NamespaceDirective) {