Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

Issue 2873943003: cleanup dart code completion contributors (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
index a9f16dfc8197d500b127cb712de39de96c2fbb54..e495a66fc45358ab45fde11b4ad4e362a0251211 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
@@ -48,16 +48,6 @@ class LocalReferenceContributor extends DartCompletionContributor {
optype.includeTypeNameSuggestions ||
optype.includeVoidReturnSuggestions ||
suggestLocalFields) {
- // If the target is in an expression
- // then resolve the outermost/entire expression
- if (node is Expression) {
- await request.resolveContainingExpression(node);
-
- // Discard any cached target information
- // because it may have changed as a result of the resolution
- node = request.target.containingNode;
- }
-
// Do not suggest local vars within the current expression
while (node is Expression) {
node = node.parent;

Powered by Google App Engine
This is Rietveld 408576698