Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

Issue 2873943003: cleanup dart code completion contributors (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart
index e58bbc7b09220f9d49da90e1f92e07ed984dd2ad..4d83221e1ff7c1b034dd639b6d57d3c5ccbdc3f3 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart
@@ -25,17 +25,8 @@ class TypeMemberContributor extends DartCompletionContributor {
@override
Future<List<CompletionSuggestion>> computeSuggestions(
DartCompletionRequest request) async {
- // Determine if the target looks like a prefixed identifier,
- // a method invocation, or a property access
- Expression parsedExpression = request.dotTarget;
- if (parsedExpression == null) {
- return EMPTY_LIST;
- }
-
- // Resolve the expression and the containing library
- await request.resolveContainingExpression(parsedExpression);
LibraryElement containingLibrary = request.libraryElement;
- // Gracefully degrade if the library element could not be resolved
+ // Gracefully degrade if the library element is not resolved
// e.g. detached part file or source change
if (containingLibrary == null) {
return EMPTY_LIST;

Powered by Google App Engine
This is Rietveld 408576698