Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

Issue 2873943003: cleanup dart code completion contributors (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
index 64bbd64f0f33a47af9602d6bf0f490de1d1a867e..ef044617237bc90d89baa5d325d7a5e585cb543f 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
@@ -181,21 +181,12 @@ class LocalLibraryContributor extends DartCompletionContributor {
return EMPTY_LIST;
}
- List<CompilationUnitElement> libraryUnits = await request.resolveUnits();
+ List<CompilationUnitElement> libraryUnits =
+ request.result.unit.element.library.units;
if (libraryUnits == null) {
return EMPTY_LIST;
}
- AstNode node = request.target.containingNode;
-
- // If the target is in an expression
- // then resolve the outermost/entire expression
- await request.resolveContainingExpression(node);
-
- // Discard any cached target information
- // because it may have changed as a result of the resolution
- node = request.target.containingNode;
-
OpType optype = (request as DartCompletionRequestImpl).opType;
LibraryElementSuggestionBuilder visitor =
new LibraryElementSuggestionBuilder(request, optype);

Powered by Google App Engine
This is Rietveld 408576698