Omnibus Observatory UI fixes:

Omnibus Observatory UI fixes:

 - Globally replace InstanceRepository with ObjectRepository. In general, instances may reference non-instances, so we should not assume we'll only get instances from the fields of instances.
 - Allow expanding context and closure refs like regular instance refs.
 - Fix display of a mirror reference's referent, which is never an instance or context.

R=aam@google.com, mfairhurst@google.com

Committed: https://github.com/dart-lang/sdk/commit/1bf31322ad2fb8c54099ec083eb5ecd5bc3de940

[rmacnak, 2017-05-09 22:26:22]

rmacnak@google.com changed reviewers:
+ aam@google.com, mfairhurst@google.com

[rmacnak, 2017-05-09 22:26:23]

Most of this CL is a boring substitution of InstanceRepository with
ObjectRepository and noise from dartfmt. The interesting bits are in
instance_ref.dart and context_ref.dart.

Context: The FooRepositories allow for using mock data in UI tests, but talk to
a real VM in Observatory.

[aam, 2017-05-09 23:36:05]

lgtm

[mfairhurst, 2017-05-09 23:37:38]

lgtm

lgtm too.


I did see this in my console while exploring the changes:

bit length overflow
code 18 bits 6->7

bit length overflow
code 18 bits 6->7

Not sure if that's a known issue or probably caused by something else.

[Cutch, 2017-05-09 23:49:02]

> I did see this in my console while exploring the changes:
> 
> bit length overflow
> code 18 bits 6->7
> 
> bit length overflow
> code 18 bits 6->7
> 

^-- the above is debug output from zlib. It is only present when you build a
DEBUG VM.

[rmacnak, 2017-05-09 23:59:59]

Description was changed from

==========
Omnibus Observatory UI fixes:

 - Globally replace InstanceRepository with ObjectRepository. In general,
instances may reference non-instances, so we should not assume we'll only get
instances from the fields of instances.
 - Allow expanding context and closures refs like regular instance refs.
 - Fix display of a mirror reference's referent, which is never an instance or
context.
==========

to

==========
Omnibus Observatory UI fixes:

 - Globally replace InstanceRepository with ObjectRepository. In general,
instances may reference non-instances, so we should not assume we'll only get
instances from the fields of instances.
 - Allow expanding context and closure refs like regular instance refs.
 - Fix display of a mirror reference's referent, which is never an instance or
context.
==========

[rmacnak, 2017-05-10 00:00:38]

Description was changed from

==========
Omnibus Observatory UI fixes:

 - Globally replace InstanceRepository with ObjectRepository. In general,
instances may reference non-instances, so we should not assume we'll only get
instances from the fields of instances.
 - Allow expanding context and closure refs like regular instance refs.
 - Fix display of a mirror reference's referent, which is never an instance or
context.
==========

to

==========
Omnibus Observatory UI fixes:

 - Globally replace InstanceRepository with ObjectRepository. In general,
instances may reference non-instances, so we should not assume we'll only get
instances from the fields of instances.
 - Allow expanding context and closure refs like regular instance refs.
 - Fix display of a mirror reference's referent, which is never an instance or
context.

R=aam@google.com, mfairhurst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1bf31322ad2fb8c54099ec083eb5ecd5bc3de940
==========

[rmacnak, 2017-05-10 00:00:39]

Committed patchset #1 (id:1) manually as
1bf31322ad2fb8c54099ec083eb5ecd5bc3de940 (presubmit successful).