Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: runtime/observatory/lib/src/elements/icdata_view.dart

Issue 2873013004: Omnibus Observatory UI fixes: (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/icdata_view.dart
diff --git a/runtime/observatory/lib/src/elements/icdata_view.dart b/runtime/observatory/lib/src/elements/icdata_view.dart
index 87c3b6c14adf6575e3eb884ebad3050f324aff66..58e7bca6b5e85b7f269e228c5b756d210ce0e0b2 100644
--- a/runtime/observatory/lib/src/elements/icdata_view.dart
+++ b/runtime/observatory/lib/src/elements/icdata_view.dart
@@ -46,7 +46,7 @@ class ICDataViewElement extends HtmlElement implements Renderable {
M.ReachableSizeRepository _reachableSizes;
M.InboundReferencesRepository _references;
M.RetainingPathRepository _retainingPaths;
- M.InstanceRepository _instances;
+ M.ObjectRepository _objects;
M.VMRef get vm => _vm;
M.IsolateRef get isolate => _isolate;
@@ -64,7 +64,7 @@ class ICDataViewElement extends HtmlElement implements Renderable {
M.ReachableSizeRepository reachableSizes,
M.InboundReferencesRepository references,
M.RetainingPathRepository retainingPaths,
- M.InstanceRepository instances,
+ M.ObjectRepository objects,
{RenderingQueue queue}) {
assert(vm != null);
assert(isolate != null);
@@ -76,7 +76,7 @@ class ICDataViewElement extends HtmlElement implements Renderable {
assert(reachableSizes != null);
assert(references != null);
assert(retainingPaths != null);
- assert(instances != null);
+ assert(objects != null);
ICDataViewElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._vm = vm;
@@ -89,7 +89,7 @@ class ICDataViewElement extends HtmlElement implements Renderable {
e._reachableSizes = reachableSizes;
e._references = references;
e._retainingPaths = retainingPaths;
- e._instances = instances;
+ e._objects = objects;
return e;
}
@@ -129,7 +129,7 @@ class ICDataViewElement extends HtmlElement implements Renderable {
new HeadingElement.h2()..text = 'ICData',
new HRElement(),
new ObjectCommonElement(_isolate, _icdata, _retainedSizes,
- _reachableSizes, _references, _retainingPaths, _instances,
+ _reachableSizes, _references, _retainingPaths, _objects,
queue: _r.queue),
new DivElement()
..classes = ['memberList']
@@ -155,7 +155,7 @@ class ICDataViewElement extends HtmlElement implements Renderable {
..children = [
_icdata.dartOwner == null
? (new SpanElement()..text = '<none>')
- : anyRef(_isolate, _icdata.dartOwner, _instances,
+ : anyRef(_isolate, _icdata.dartOwner, _objects,
queue: _r.queue)
]
],
@@ -171,7 +171,7 @@ class ICDataViewElement extends HtmlElement implements Renderable {
_icdata.argumentsDescriptor == null
? (new SpanElement()..text = '<none>')
: anyRef(
- _isolate, _icdata.argumentsDescriptor, _instances,
+ _isolate, _icdata.argumentsDescriptor, _objects,
queue: _r.queue)
]
],
@@ -186,7 +186,7 @@ class ICDataViewElement extends HtmlElement implements Renderable {
..children = [
_icdata.entries == null
? (new SpanElement()..text = '<none>')
- : anyRef(_isolate, _icdata.entries, _instances,
+ : anyRef(_isolate, _icdata.entries, _objects,
queue: _r.queue)
]
]

Powered by Google App Engine
This is Rietveld 408576698