runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart - Issue 2873013004: Omnibus Observatory UI fixes:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

Issue 2873013004: Omnibus Observatory UI fixes: (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/icdata_view/element_test.dart ('k') | runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

diff --git a/runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart b/runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

index 0e80f1ce8bed3d65c58d5ec182c2c9d21eb4a81f..abf04f8f7bd317d524ca406dbdb88bca259bd4a8 100644

--- a/runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

+++ b/runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

@@ -19,10 +19,9 @@ main() {

const isolate = const IsolateRefMock();

const object = const InstanceRefMock();

final inbounds = new InboundReferencesRepositoryMock();

- final instances = new InstanceRepositoryMock();

+ final objects = new ObjectRepositoryMock();

test('instantiation', () {

- final e =

- new InboundReferencesElement(isolate, object, inbounds, instances);

+ final e = new InboundReferencesElement(isolate, object, inbounds, objects);

expect(e, isNotNull, reason: 'element correctly created');

expect(e.isolate, equals(isolate));

expect(e.object, equals(object));

@@ -39,9 +38,8 @@ main() {

invoked = true;

return references;

}, count: 1));

- final instances = new InstanceRepositoryMock();

- final e =

- new InboundReferencesElement(isolate, object, inbounds, instances);

+ final objects = new ObjectRepositoryMock();

+ final e = new InboundReferencesElement(isolate, object, inbounds, objects);

document.body.append(e);

await e.onRendered.first;

expect(invoked, isFalse);