Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: runtime/observatory/lib/src/elements/object_common.dart

Issue 2873013004: Omnibus Observatory UI fixes: (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/object_common.dart
diff --git a/runtime/observatory/lib/src/elements/object_common.dart b/runtime/observatory/lib/src/elements/object_common.dart
index 0db760d67fcd650f31307e8c188f456a956b8738..1fafc22c946c7f1f5b27c90bd97a58bcc817722d 100644
--- a/runtime/observatory/lib/src/elements/object_common.dart
+++ b/runtime/observatory/lib/src/elements/object_common.dart
@@ -32,7 +32,7 @@ class ObjectCommonElement extends HtmlElement implements Renderable {
M.ReachableSizeRepository _reachableSizes;
M.InboundReferencesRepository _references;
M.RetainingPathRepository _retainingPaths;
- M.InstanceRepository _instances;
+ M.ObjectRepository _objects;
M.Guarded<M.Instance> _retainedSize = null;
bool _loadingRetainedBytes = false;
M.Guarded<M.Instance> _reachableSize = null;
@@ -48,7 +48,7 @@ class ObjectCommonElement extends HtmlElement implements Renderable {
M.ReachableSizeRepository reachableSizes,
M.InboundReferencesRepository references,
M.RetainingPathRepository retainingPaths,
- M.InstanceRepository instances,
+ M.ObjectRepository objects,
{RenderingQueue queue}) {
assert(isolate != null);
assert(object != null);
@@ -56,7 +56,7 @@ class ObjectCommonElement extends HtmlElement implements Renderable {
assert(reachableSizes != null);
assert(references != null);
assert(retainingPaths != null);
- assert(instances != null);
+ assert(objects != null);
ObjectCommonElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._isolate = isolate;
@@ -64,7 +64,7 @@ class ObjectCommonElement extends HtmlElement implements Renderable {
e._retainedSizes = retainedSizes;
e._reachableSizes = reachableSizes;
e._references = references;
- e._instances = instances;
+ e._objects = objects;
e._retainingPaths = retainingPaths;
return e;
}
@@ -89,10 +89,10 @@ class ObjectCommonElement extends HtmlElement implements Renderable {
void render() {
_path = _path ??
- new RetainingPathElement(_isolate, _object, _retainingPaths, _instances,
+ new RetainingPathElement(_isolate, _object, _retainingPaths, _objects,
queue: _r.queue);
_inbounds = _inbounds ??
- new InboundReferencesElement(_isolate, _object, _references, _instances,
+ new InboundReferencesElement(_isolate, _object, _references, _objects,
queue: _r.queue);
children = [
new DivElement()
« no previous file with comments | « runtime/observatory/lib/src/elements/megamorphiccache_view.dart ('k') | runtime/observatory/lib/src/elements/object_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698