runtime/observatory/lib/src/elements/source_inset.dart - Issue 2873013004: Omnibus Observatory UI fixes:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/source_inset.dart

Issue 2873013004: Omnibus Observatory UI fixes: (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/elements/singletargetcache_view.dart ('k') | runtime/observatory/lib/src/elements/strongly_reachable_instances.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/source_inset.dart

diff --git a/runtime/observatory/lib/src/elements/source_inset.dart b/runtime/observatory/lib/src/elements/source_inset.dart

index a51cc1e4ec295cb897148cf6ea5a901b29f88ac0..f507f72f178235a1e0e6d4e9effda36112bab281 100644

--- a/runtime/observatory/lib/src/elements/source_inset.dart

+++ b/runtime/observatory/lib/src/elements/source_inset.dart

@@ -21,7 +21,7 @@ class SourceInsetElement extends HtmlElement implements Renderable {

M.IsolateRef _isolate;

M.SourceLocation _location;

M.ScriptRepository _scripts;

- M.InstanceRepository _instances;

+ M.ObjectRepository _objects;

M.EventRepository _events;

int _currentPos;

bool _inDebuggerContext;

@@ -34,7 +34,7 @@ class SourceInsetElement extends HtmlElement implements Renderable {

M.IsolateRef isolate,

M.SourceLocation location,

M.ScriptRepository scripts,

- M.InstanceRepository instances,

+ M.ObjectRepository objects,

M.EventRepository events,

{int currentPos,

bool inDebuggerContext: false,

@@ -43,7 +43,7 @@ class SourceInsetElement extends HtmlElement implements Renderable {

assert(isolate != null);

assert(location != null);

assert(scripts != null);

- assert(instances != null);

+ assert(objects != null);

assert(events != null);

assert(inDebuggerContext != null);

assert(variables != null);

@@ -52,7 +52,7 @@ class SourceInsetElement extends HtmlElement implements Renderable {

e._isolate = isolate;

e._location = location;

e._scripts = scripts;

- e._instances = instances;

+ e._objects = objects;

e._events = events;

e._currentPos = currentPos;

e._inDebuggerContext = inDebuggerContext;

@@ -78,7 +78,7 @@ class SourceInsetElement extends HtmlElement implements Renderable {

void render() {

children = [

new ScriptInsetElement(

- _isolate, _location.script, _scripts, _instances, _events,

+ _isolate, _location.script, _scripts, _objects, _events,

startPos: _location.tokenPos,

endPos: _location.endTokenPos,

currentPos: _currentPos,