Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: runtime/observatory/lib/src/elements/context_ref.dart

Issue 2873013004: Omnibus Observatory UI fixes: (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/context_ref.dart
diff --git a/runtime/observatory/lib/src/elements/context_ref.dart b/runtime/observatory/lib/src/elements/context_ref.dart
index 7628396a9a7d347c8843ad5ac4f7f92c42b91f08..63d1464276f4337e2c6902679db33715ae2915f3 100644
--- a/runtime/observatory/lib/src/elements/context_ref.dart
+++ b/runtime/observatory/lib/src/elements/context_ref.dart
@@ -4,13 +4,16 @@
import 'dart:html';
import 'dart:async';
-import 'package:observatory/models.dart' as M show IsolateRef, ContextRef;
+import 'package:observatory/models.dart' as M;
+import 'package:observatory/src/elements/curly_block.dart';
+import 'package:observatory/src/elements/helpers/any_ref.dart';
import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory/src/elements/helpers/tag.dart';
import 'package:observatory/src/elements/helpers/uris.dart';
class ContextRefElement extends HtmlElement implements Renderable {
- static const tag = const Tag<ContextRefElement>('context-ref');
+ static const tag = const Tag<ContextRefElement>('context-ref',
+ dependencies: const [CurlyBlockElement.tag]);
RenderingScheduler<ContextRefElement> _r;
@@ -18,18 +21,24 @@ class ContextRefElement extends HtmlElement implements Renderable {
M.IsolateRef _isolate;
M.ContextRef _context;
+ M.ObjectRepository _objects;
+ M.Context _loadedContext;
+ bool _expanded = false;
M.IsolateRef get isolate => _isolate;
M.ContextRef get context => _context;
- factory ContextRefElement(M.IsolateRef isolate, M.ContextRef context,
+ factory ContextRefElement(
+ M.IsolateRef isolate, M.ContextRef context, M.ObjectRepository objects,
{RenderingQueue queue}) {
assert(isolate != null);
assert(context != null);
+ assert(objects != null);
ContextRefElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._isolate = isolate;
e._context = context;
+ e._objects = objects;
return e;
}
@@ -48,6 +57,11 @@ class ContextRefElement extends HtmlElement implements Renderable {
children = [];
}
+ Future _refresh() async {
+ _loadedContext = await _objects.get(_isolate, _context.id);
+ _r.dirty();
+ }
+
void render() {
children = [
new AnchorElement(href: Uris.inspect(_isolate, object: _context))
@@ -55,8 +69,69 @@ class ContextRefElement extends HtmlElement implements Renderable {
new SpanElement()
..classes = ['emphasize']
..text = 'Context',
- new SpanElement()..text = ' (${_context.length})'
+ new SpanElement()..text = ' (${_context.length})',
+ ],
+ new SpanElement()..text = ' ',
+ new CurlyBlockElement(expanded: _expanded, queue: _r.queue)
+ ..content = [
+ new DivElement()
+ ..classes = ['indent']
+ ..children = _createValue()
]
+ ..onToggle.listen((e) async {
+ _expanded = e.control.expanded;
+ if (_expanded) {
+ e.control.disabled = true;
+ await _refresh();
+ e.control.disabled = false;
+ }
+ })
+ ];
+ }
+
+ List<Element> _createValue() {
+ if (_loadedContext == null) {
+ return [new SpanElement()..text = 'Loading...'];
+ }
+ var members = new List<Element>();
+ if (_loadedContext.parentContext != null) {
+ members.add(new DivElement()
+ ..classes = ['memberItem']
+ ..children = [
+ new DivElement()
+ ..classes = ['memberName']
+ ..text = 'parent context',
+ new DivElement()
+ ..classes = ['memberName']
+ ..children = [
+ new ContextRefElement(
+ _isolate, _loadedContext.parentContext, _objects,
+ queue: _r.queue)
+ ]
+ ]);
+ }
+ if (_loadedContext.variables.isNotEmpty) {
+ var variables = _loadedContext.variables.toList();
+ for (var index = 0; index < variables.length; index++) {
+ var variable = variables[index];
+ members.add(new DivElement()
+ ..classes = ['memberItem']
+ ..children = [
+ new DivElement()
+ ..classes = ['memberName']
+ ..text = '[ $index ]',
+ new DivElement()
+ ..classes = ['memberName']
+ ..children = [
+ anyRef(_isolate, variable.value, _objects, queue: _r.queue)
+ ]
+ ]);
+ }
+ }
+ return [
+ new DivElement()
+ ..classes = ['memberList']
+ ..children = members
];
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/code_view.dart ('k') | runtime/observatory/lib/src/elements/context_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698