[LayoutNG] Introduce NGPositionedFloat.

[LayoutNG] Introduce NGPositionedFloat.

This pulls out the positioned fragment info from NGFloatingObject.
This allows for in a followup to perform layout on a NGUnpositionedFloat
post positioning (to allow for fragmentation).

BUG=635619
Review-Url: https://codereview.chromium.org/2872593003
Cr-Commit-Position: refs/heads/master@{#470194}
Committed: https://chromium.googlesource.com/chromium/src/+/1fbf200f4fd34bf2b6f77818a60a472763046e9b

[ikilpatrick, 2017-05-08 17:26:56]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 17:27:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-05-08 17:30:28]

ikilpatrick@chromium.org changed reviewers:
+ glebl@chromium.org

[Gleb Lanbin, 2017-05-08 19:03:38]

LGTM with minor comments

https://codereview.chromium.org/2872593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):

https://codereview.chromium.org/2872593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:69: const
NGPositionedFloat& ng_positioned_float,
positioned_float or float

https://codereview.chromium.org/2872593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h (right):

https://codereview.chromium.org/2872593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h:26:
Vector<NGPositionedFloat>* positioned_floats,
please change the API to return the positioned_floats list instead.

[ikilpatrick, 2017-05-08 19:16:08]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 19:16:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-05-08 19:18:19]

https://codereview.chromium.org/2872593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):

https://codereview.chromium.org/2872593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:69: const
NGPositionedFloat& ng_positioned_float,
On 2017/05/08 19:03:38, Gleb Lanbin wrote:
> positioned_float or float

Done.

https://codereview.chromium.org/2872593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h (right):

https://codereview.chromium.org/2872593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h:26:
Vector<NGPositionedFloat>* positioned_floats,
On 2017/05/08 19:03:38, Gleb Lanbin wrote:
> please change the API to return the positioned_floats list instead.

Done.

[ikilpatrick, 2017-05-08 20:32:09]

The CQ bit was unchecked by ikilpatrick@chromium.org

[ikilpatrick, 2017-05-08 20:32:14]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2017-05-08 20:32:15]

The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org
Link to the patchset: https://codereview.chromium.org/2872593003/#ps40001
(title: "address comments.")

[commit-bot: I haz the power, 2017-05-08 20:32:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 20:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 20:47:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[cbiesinger, 2017-05-08 22:02:34]

lgtm

[cbiesinger, 2017-05-08 22:03:00]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:05:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-05-08 22:06:25]

The CQ bit was unchecked by ikilpatrick@chromium.org

[ikilpatrick, 2017-05-08 22:06:27]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:06:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:17:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494281187388040,
"parent_rev": "43d6f3c682549d986b9b69b28f58f7c034885f1f", "commit_rev":
"1fbf200f4fd34bf2b6f77818a60a472763046e9b"}

[commit-bot: I haz the power, 2017-05-09 04:17:53]

Description was changed from

==========
[LayoutNG] Introduce NGPositionedFloat.

This pulls out the positioned fragment info from NGFloatingObject.
This allows for in a followup to perform layout on a NGUnpositionedFloat
post positioning (to allow for fragmentation).

BUG=635619
==========

to

==========
[LayoutNG] Introduce NGPositionedFloat.

This pulls out the positioned fragment info from NGFloatingObject.
This allows for in a followup to perform layout on a NGUnpositionedFloat
post positioning (to allow for fragmentation).

BUG=635619

Review-Url: https://codereview.chromium.org/2872593003
Cr-Commit-Position: refs/heads/master@{#470194}
Committed:
https://chromium.googlesource.com/chromium/src/+/1fbf200f4fd34bf2b6f77818a60a...
==========

[commit-bot: I haz the power, 2017-05-09 04:17:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1fbf200f4fd34bf2b6f77818a60a...