Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

Issue 2872593003: [LayoutNG] Introduce NGPositionedFloat. (Closed)
Patch Set: address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
index e2403211bf3ad016aae96aa2e542645b076567fa..d621f849d7991dd8acf10d2f182831d14665a619 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
@@ -10,12 +10,11 @@
#include "core/layout/ng/geometry/ng_margin_strut.h"
#include "core/layout/ng/ng_floating_object.h"
#include "core/layout/ng/ng_physical_fragment.h"
+#include "core/layout/ng/ng_positioned_float.h"
#include "platform/wtf/Optional.h"
namespace blink {
-struct NGFloatingObject;
-
class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
public:
// This modifies the passed-in children vector.
@@ -23,7 +22,7 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
NGPhysicalSize size,
NGPhysicalSize overflow,
Vector<RefPtr<NGPhysicalFragment>>& children,
- Vector<RefPtr<NGFloatingObject>>& positioned_floats,
+ Vector<NGPositionedFloat>& positioned_floats,
const WTF::Optional<NGLogicalOffset>& bfc_offset,
const NGMarginStrut& end_margin_strut,
RefPtr<NGBreakToken> break_token = nullptr);
@@ -38,7 +37,7 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
// List of positioned floats that need to be copied to the old layout tree.
// TODO(layout-ng): remove this once we change painting code to handle floats
// differently.
- const Vector<RefPtr<NGFloatingObject>>& PositionedFloats() const {
+ const Vector<NGPositionedFloat>& PositionedFloats() const {
return positioned_floats_;
}
@@ -51,7 +50,7 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
private:
NGPhysicalSize overflow_;
Vector<RefPtr<NGPhysicalFragment>> children_;
- Vector<RefPtr<NGFloatingObject>> positioned_floats_;
+ Vector<NGPositionedFloat> positioned_floats_;
const WTF::Optional<NGLogicalOffset> bfc_offset_;
const NGMarginStrut end_margin_strut_;
};

Powered by Google App Engine
This is Rietveld 408576698