third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc - Issue 2872593003: [LayoutNG] Introduce NGPositionedFloat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

Issue 2872593003: [LayoutNG] Introduce NGPositionedFloat. (Closed)

Patch Set: address comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/BUILD.gn ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

index d99a083a6a3f9d68818c176646be1dbe5b9c46a6..827ec6a991c3925c7aa8ce8da9e8c3668aed33cc 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

@@ -393,9 +393,8 @@ void NGInlineLayoutAlgorithm::LayoutAndPositionFloat(

float_does_not_fit) {

container_builder_.AddUnpositionedFloat(floating_object);

} else {

- floating_object->logical_offset =

- PositionFloat(floating_object.Get(), MutableConstraintSpace());

- container_builder_.MutablePositionedFloats().push_back(floating_object);

+ container_builder_.MutablePositionedFloats().push_back(

+ PositionFloat(floating_object.Get(), MutableConstraintSpace()));

FindNextLayoutOpportunity();

}