third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc - Issue 2872593003: [LayoutNG] Introduce NGPositionedFloat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

Issue 2872593003: [LayoutNG] Introduce NGPositionedFloat. (Closed)

Patch Set: address comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

index 01fe88e8638bfef6854f9fda34b74ddd617f44ac..f9d504ef81b166d163bc2b9cd69df9df9979fdd0 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

@@ -93,10 +93,9 @@ void PositionPendingFloats(LayoutUnit origin_block_offset,

DCHECK(container_builder->BfcOffset())

<< "Parent BFC offset should be known here";

const auto& floating_objects = container_builder->UnpositionedFloats();

- PositionFloats(origin_block_offset,

- container_builder->BfcOffset().value().block_offset,

- floating_objects, space);

- container_builder->MutablePositionedFloats().AppendVector(floating_objects);

+ container_builder->MutablePositionedFloats().AppendVector(PositionFloats(

+ origin_block_offset, container_builder->BfcOffset().value().block_offset,

+ floating_objects, space));

container_builder->MutableUnpositionedFloats().clear();

}