Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_floating_object.h

Issue 2872593003: [LayoutNG] Introduce NGPositionedFloat. (Closed)
Patch Set: address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h b/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
index bf8e009d05defdfeddf5a3fdd4b08c294adca0ba..c7b5a503ddb00af02e09d999d0edafb1558d8029 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
@@ -50,31 +50,17 @@ struct CORE_EXPORT NGFloatingObject : public RefCounted<NGFloatingObject> {
NGLogicalOffset origin_offset;
NGLogicalOffset from_offset;
- // Calculated logical offset. It's never {@code nullopt} for a positioned
- // float.
- WTF::Optional<NGLogicalOffset> logical_offset;
-
// Writing mode of the float's constraint space.
NGWritingMode writing_mode;
RefPtr<NGPhysicalFragment> fragment;
- // In the case where a legacy FloatingObject is attached to not its own
- // parent, e.g. a float surrounded by a bunch of nested empty divs,
- // NG float fragment's LeftOffset() cannot be used as legacy FloatingObject's
- // left offset because that offset should be relative to the original float
- // parent.
- // {@code left_offset} is calculated when we know to which parent this float
- // would be attached.
- LayoutUnit left_offset;
-
bool IsLeft() const { return exclusion_type == NGExclusion::kFloatLeft; }
bool IsRight() const { return exclusion_type == NGExclusion::kFloatRight; }
String ToString() const {
- return String::Format("Type: '%d' Fragment: '%s'", exclusion_type,
- fragment->ToString().Ascii().data());
+ return String::Format("Type: '%d'", exclusion_type);
}
private:
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_node.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698