Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)

Created:
3 years, 7 months ago by xiaofengzhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from audio/video renderer related code in media/ base::ScopedVector is deprecated, see bug. BUG=554289, 588249 Review-Url: https://codereview.chromium.org/2871503002 Cr-Commit-Position: refs/heads/master@{#471186} Committed: https://chromium.googlesource.com/chromium/src/+/47778d3b6f6e5da0a698689d9c4c3e7e3cf0f51e

Patch Set 1 : Remove ScopedVector from audio/video render related code in media/ #

Total comments: 7

Patch Set 2 : Address xhwang's comments and delete some useless includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -77 lines) Patch
M media/base/decoder_factory.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M media/base/decoder_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M media/filters/decoder_selector.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/filters/decoder_selector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/decoder_stream.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 1 3 chunks +11 lines, -10 lines 0 comments Download
M media/mojo/clients/mojo_decoder_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/clients/mojo_decoder_factory.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M media/renderers/default_renderer_factory.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 3 chunks +11 lines, -9 lines 0 comments Download
M media/renderers/video_renderer_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 1 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 41 (34 generated)
xiaofengzhang
Hi xhwang@ Could you help to review this patch? Thanks a lot!
3 years, 7 months ago (2017-05-10 08:56:57 UTC) #20
xhwang
Thank you for working on this! The CL looks mostly good. I just have a ...
3 years, 7 months ago (2017-05-10 16:41:24 UTC) #23
xiaofengzhang
https://codereview.chromium.org/2871503002/diff/80001/media/base/decoder_factory.h File media/base/decoder_factory.h (right): https://codereview.chromium.org/2871503002/diff/80001/media/base/decoder_factory.h#newcode12 media/base/decoder_factory.h:12: #include "base/memory/ptr_util.h" On 2017/05/10 16:41:24, xhwang wrote: > Not ...
3 years, 7 months ago (2017-05-11 06:34:43 UTC) #25
xiaofengzhang
On 2017/05/11 06:34:43, xiaofengzhang wrote: > https://codereview.chromium.org/2871503002/diff/80001/media/base/decoder_factory.h > File media/base/decoder_factory.h (right): > > https://codereview.chromium.org/2871503002/diff/80001/media/base/decoder_factory.h#newcode12 > ...
3 years, 7 months ago (2017-05-11 07:50:12 UTC) #27
xhwang
lgtm
3 years, 7 months ago (2017-05-11 16:49:37 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871503002/120001
3 years, 7 months ago (2017-05-12 01:36:31 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 02:25:26 UTC) #41
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/47778d3b6f6e5da0a698689d9c4c...

Powered by Google App Engine
This is Rietveld 408576698