Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: media/renderers/default_renderer_factory.cc

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)
Patch Set: Address xhwang's comments and delete some useless includes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/renderers/default_renderer_factory.h ('k') | media/renderers/video_renderer_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/renderers/default_renderer_factory.h" 5 #include "media/renderers/default_renderer_factory.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 24 matching lines...) Expand all
35 MediaLog* media_log, 35 MediaLog* media_log,
36 DecoderFactory* decoder_factory, 36 DecoderFactory* decoder_factory,
37 const GetGpuFactoriesCB& get_gpu_factories_cb) 37 const GetGpuFactoriesCB& get_gpu_factories_cb)
38 : media_log_(media_log), 38 : media_log_(media_log),
39 decoder_factory_(decoder_factory), 39 decoder_factory_(decoder_factory),
40 get_gpu_factories_cb_(get_gpu_factories_cb) {} 40 get_gpu_factories_cb_(get_gpu_factories_cb) {}
41 41
42 DefaultRendererFactory::~DefaultRendererFactory() { 42 DefaultRendererFactory::~DefaultRendererFactory() {
43 } 43 }
44 44
45 ScopedVector<AudioDecoder> DefaultRendererFactory::CreateAudioDecoders( 45 std::vector<std::unique_ptr<AudioDecoder>>
46 DefaultRendererFactory::CreateAudioDecoders(
46 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner) { 47 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner) {
47 // Create our audio decoders and renderer. 48 // Create our audio decoders and renderer.
48 ScopedVector<AudioDecoder> audio_decoders; 49 std::vector<std::unique_ptr<AudioDecoder>> audio_decoders;
49 50
50 #if !defined(MEDIA_DISABLE_FFMPEG) 51 #if !defined(MEDIA_DISABLE_FFMPEG)
51 audio_decoders.push_back( 52 audio_decoders.push_back(
52 new FFmpegAudioDecoder(media_task_runner, media_log_)); 53 base::MakeUnique<FFmpegAudioDecoder>(media_task_runner, media_log_));
53 #endif 54 #endif
54 55
55 // Use an external decoder only if we cannot otherwise decode in the 56 // Use an external decoder only if we cannot otherwise decode in the
56 // renderer. 57 // renderer.
57 if (decoder_factory_) 58 if (decoder_factory_)
58 decoder_factory_->CreateAudioDecoders(media_task_runner, &audio_decoders); 59 decoder_factory_->CreateAudioDecoders(media_task_runner, &audio_decoders);
59 60
60 return audio_decoders; 61 return audio_decoders;
61 } 62 }
62 63
63 ScopedVector<VideoDecoder> DefaultRendererFactory::CreateVideoDecoders( 64 std::vector<std::unique_ptr<VideoDecoder>>
65 DefaultRendererFactory::CreateVideoDecoders(
64 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 66 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
65 const RequestSurfaceCB& request_surface_cb, 67 const RequestSurfaceCB& request_surface_cb,
66 GpuVideoAcceleratorFactories* gpu_factories) { 68 GpuVideoAcceleratorFactories* gpu_factories) {
67 // Create our video decoders and renderer. 69 // Create our video decoders and renderer.
68 ScopedVector<VideoDecoder> video_decoders; 70 std::vector<std::unique_ptr<VideoDecoder>> video_decoders;
69 71
70 // Prefer an external decoder since one will only exist if it is hardware 72 // Prefer an external decoder since one will only exist if it is hardware
71 // accelerated. 73 // accelerated.
72 if (gpu_factories) { 74 if (gpu_factories) {
73 // |gpu_factories_| requires that its entry points be called on its 75 // |gpu_factories_| requires that its entry points be called on its
74 // |GetTaskRunner()|. Since |pipeline_| will own decoders created from the 76 // |GetTaskRunner()|. Since |pipeline_| will own decoders created from the
75 // factories, require that their message loops are identical. 77 // factories, require that their message loops are identical.
76 DCHECK(gpu_factories->GetTaskRunner() == media_task_runner.get()); 78 DCHECK(gpu_factories->GetTaskRunner() == media_task_runner.get());
77 79
78 if (decoder_factory_) { 80 if (decoder_factory_) {
79 decoder_factory_->CreateVideoDecoders(media_task_runner, gpu_factories, 81 decoder_factory_->CreateVideoDecoders(media_task_runner, gpu_factories,
80 &video_decoders); 82 &video_decoders);
81 } 83 }
82 video_decoders.push_back( 84 video_decoders.push_back(base::MakeUnique<GpuVideoDecoder>(
83 new GpuVideoDecoder(gpu_factories, request_surface_cb, media_log_)); 85 gpu_factories, request_surface_cb, media_log_));
84 } 86 }
85 87
86 #if !defined(MEDIA_DISABLE_LIBVPX) 88 #if !defined(MEDIA_DISABLE_LIBVPX)
87 video_decoders.push_back(new VpxVideoDecoder()); 89 video_decoders.push_back(base::MakeUnique<VpxVideoDecoder>());
88 #endif 90 #endif
89 91
90 #if !defined(MEDIA_DISABLE_FFMPEG) && !defined(DISABLE_FFMPEG_VIDEO_DECODERS) 92 #if !defined(MEDIA_DISABLE_FFMPEG) && !defined(DISABLE_FFMPEG_VIDEO_DECODERS)
91 video_decoders.push_back(new FFmpegVideoDecoder(media_log_)); 93 video_decoders.push_back(base::MakeUnique<FFmpegVideoDecoder>(media_log_));
92 #endif 94 #endif
93 95
94 return video_decoders; 96 return video_decoders;
95 } 97 }
96 98
97 std::unique_ptr<Renderer> DefaultRendererFactory::CreateRenderer( 99 std::unique_ptr<Renderer> DefaultRendererFactory::CreateRenderer(
98 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 100 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
99 const scoped_refptr<base::TaskRunner>& worker_task_runner, 101 const scoped_refptr<base::TaskRunner>& worker_task_runner,
100 AudioRendererSink* audio_renderer_sink, 102 AudioRendererSink* audio_renderer_sink,
101 VideoRendererSink* video_renderer_sink, 103 VideoRendererSink* video_renderer_sink,
(...skipping 27 matching lines...) Expand all
129 base::Bind(&DefaultRendererFactory::CreateVideoDecoders, 131 base::Bind(&DefaultRendererFactory::CreateVideoDecoders,
130 base::Unretained(this), media_task_runner, request_surface_cb, 132 base::Unretained(this), media_task_runner, request_surface_cb,
131 gpu_factories), 133 gpu_factories),
132 true, gpu_factories, media_log_)); 134 true, gpu_factories, media_log_));
133 135
134 return base::MakeUnique<RendererImpl>( 136 return base::MakeUnique<RendererImpl>(
135 media_task_runner, std::move(audio_renderer), std::move(video_renderer)); 137 media_task_runner, std::move(audio_renderer), std::move(video_renderer));
136 } 138 }
137 139
138 } // namespace media 140 } // namespace media
OLDNEW
« no previous file with comments | « media/renderers/default_renderer_factory.h ('k') | media/renderers/video_renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698