Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: media/renderers/default_renderer_factory.h

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)
Patch Set: Remove ScopedVector from audio/video render related code in media/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_ 5 #ifndef MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_
6 #define MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_ 6 #define MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector>
9 10
10 #include "base/callback.h" 11 #include "base/callback.h"
11 #include "base/macros.h" 12 #include "base/macros.h"
12 #include "base/memory/scoped_vector.h" 13 #include "base/memory/ptr_util.h"
xhwang 2017/05/10 16:41:24 not needed
xiaofengzhang 2017/05/11 06:34:43 Done.
13 #include "media/base/media_export.h" 14 #include "media/base/media_export.h"
14 #include "media/base/renderer_factory.h" 15 #include "media/base/renderer_factory.h"
15 16
16 namespace media { 17 namespace media {
17 18
18 class AudioDecoder; 19 class AudioDecoder;
19 class AudioRendererSink; 20 class AudioRendererSink;
20 class DecoderFactory; 21 class DecoderFactory;
21 class GpuVideoAcceleratorFactories; 22 class GpuVideoAcceleratorFactories;
22 class MediaLog; 23 class MediaLog;
23 class VideoDecoder; 24 class VideoDecoder;
24 class VideoRendererSink; 25 class VideoRendererSink;
25 26
26 using CreateAudioDecodersCB = 27 using CreateAudioDecodersCB =
27 base::RepeatingCallback<ScopedVector<AudioDecoder>()>; 28 base::RepeatingCallback<std::vector<std::unique_ptr<AudioDecoder>>()>;
28 using CreateVideoDecodersCB = 29 using CreateVideoDecodersCB =
29 base::RepeatingCallback<ScopedVector<VideoDecoder>()>; 30 base::RepeatingCallback<std::vector<std::unique_ptr<VideoDecoder>>()>;
30 31
31 // The default factory class for creating RendererImpl. 32 // The default factory class for creating RendererImpl.
32 class MEDIA_EXPORT DefaultRendererFactory : public RendererFactory { 33 class MEDIA_EXPORT DefaultRendererFactory : public RendererFactory {
33 public: 34 public:
34 using GetGpuFactoriesCB = base::Callback<GpuVideoAcceleratorFactories*()>; 35 using GetGpuFactoriesCB = base::Callback<GpuVideoAcceleratorFactories*()>;
35 36
36 DefaultRendererFactory(MediaLog* media_log, 37 DefaultRendererFactory(MediaLog* media_log,
37 DecoderFactory* decoder_factory, 38 DecoderFactory* decoder_factory,
38 const GetGpuFactoriesCB& get_gpu_factories_cb); 39 const GetGpuFactoriesCB& get_gpu_factories_cb);
39 ~DefaultRendererFactory() final; 40 ~DefaultRendererFactory() final;
40 41
41 std::unique_ptr<Renderer> CreateRenderer( 42 std::unique_ptr<Renderer> CreateRenderer(
42 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 43 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
43 const scoped_refptr<base::TaskRunner>& worker_task_runner, 44 const scoped_refptr<base::TaskRunner>& worker_task_runner,
44 AudioRendererSink* audio_renderer_sink, 45 AudioRendererSink* audio_renderer_sink,
45 VideoRendererSink* video_renderer_sink, 46 VideoRendererSink* video_renderer_sink,
46 const RequestSurfaceCB& request_surface_cb) final; 47 const RequestSurfaceCB& request_surface_cb) final;
47 48
48 private: 49 private:
49 ScopedVector<AudioDecoder> CreateAudioDecoders( 50 std::vector<std::unique_ptr<AudioDecoder>> CreateAudioDecoders(
50 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner); 51 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner);
51 ScopedVector<VideoDecoder> CreateVideoDecoders( 52 std::vector<std::unique_ptr<VideoDecoder>> CreateVideoDecoders(
52 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 53 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
53 const RequestSurfaceCB& request_surface_cb, 54 const RequestSurfaceCB& request_surface_cb,
54 GpuVideoAcceleratorFactories* gpu_factories); 55 GpuVideoAcceleratorFactories* gpu_factories);
55 56
56 MediaLog* media_log_; 57 MediaLog* media_log_;
57 58
58 // Factory to create extra audio and video decoders. 59 // Factory to create extra audio and video decoders.
59 // Could be nullptr if not extra decoders are available. 60 // Could be nullptr if not extra decoders are available.
60 DecoderFactory* decoder_factory_; 61 DecoderFactory* decoder_factory_;
61 62
62 // Creates factories for supporting video accelerators. May be null. 63 // Creates factories for supporting video accelerators. May be null.
63 GetGpuFactoriesCB get_gpu_factories_cb_; 64 GetGpuFactoriesCB get_gpu_factories_cb_;
64 65
65 DISALLOW_COPY_AND_ASSIGN(DefaultRendererFactory); 66 DISALLOW_COPY_AND_ASSIGN(DefaultRendererFactory);
66 }; 67 };
67 68
68 } // namespace media 69 } // namespace media
69 70
70 #endif // MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_ 71 #endif // MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698