Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: media/filters/decoder_selector.h

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)
Patch Set: Address xhwang's comments and delete some useless includes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/filters/audio_decoder_selector_unittest.cc ('k') | media/filters/decoder_selector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_FILTERS_DECODER_SELECTOR_H_ 5 #ifndef MEDIA_FILTERS_DECODER_SELECTOR_H_
6 #define MEDIA_FILTERS_DECODER_SELECTOR_H_ 6 #define MEDIA_FILTERS_DECODER_SELECTOR_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector>
9 10
10 #include "base/callback.h" 11 #include "base/callback.h"
11 #include "base/macros.h" 12 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 13 #include "base/memory/ref_counted.h"
13 #include "base/memory/scoped_vector.h"
14 #include "base/memory/weak_ptr.h" 14 #include "base/memory/weak_ptr.h"
15 #include "build/build_config.h" 15 #include "build/build_config.h"
16 #include "media/base/demuxer_stream.h" 16 #include "media/base/demuxer_stream.h"
17 #include "media/base/pipeline_status.h" 17 #include "media/base/pipeline_status.h"
18 #include "media/filters/decoder_stream_traits.h" 18 #include "media/filters/decoder_stream_traits.h"
19 19
20 namespace base { 20 namespace base {
21 class SingleThreadTaskRunner; 21 class SingleThreadTaskRunner;
22 } 22 }
23 23
(...skipping 11 matching lines...) Expand all
35 template<DemuxerStream::Type StreamType> 35 template<DemuxerStream::Type StreamType>
36 class MEDIA_EXPORT DecoderSelector { 36 class MEDIA_EXPORT DecoderSelector {
37 public: 37 public:
38 typedef DecoderStreamTraits<StreamType> StreamTraits; 38 typedef DecoderStreamTraits<StreamType> StreamTraits;
39 typedef typename StreamTraits::DecoderType Decoder; 39 typedef typename StreamTraits::DecoderType Decoder;
40 typedef typename StreamTraits::DecoderConfigType DecoderConfig; 40 typedef typename StreamTraits::DecoderConfigType DecoderConfig;
41 41
42 // Callback to create a list of decoders to select from. 42 // Callback to create a list of decoders to select from.
43 // TODO(xhwang): Use a DecoderFactory to create decoders one by one as needed, 43 // TODO(xhwang): Use a DecoderFactory to create decoders one by one as needed,
44 // instead of creating a list of decoders all at once. 44 // instead of creating a list of decoders all at once.
45 using CreateDecodersCB = base::RepeatingCallback<ScopedVector<Decoder>()>; 45 using CreateDecodersCB =
46 base::RepeatingCallback<std::vector<std::unique_ptr<Decoder>>()>;
46 47
47 // Indicates completion of Decoder selection. 48 // Indicates completion of Decoder selection.
48 // - First parameter: The initialized Decoder. If it's set to NULL, then 49 // - First parameter: The initialized Decoder. If it's set to NULL, then
49 // Decoder initialization failed. 50 // Decoder initialization failed.
50 // - Second parameter: The initialized DecryptingDemuxerStream. If it's not 51 // - Second parameter: The initialized DecryptingDemuxerStream. If it's not
51 // NULL, then a DecryptingDemuxerStream is created and initialized to do 52 // NULL, then a DecryptingDemuxerStream is created and initialized to do
52 // decryption for the initialized Decoder. 53 // decryption for the initialized Decoder.
53 // Note: The caller owns selected Decoder and DecryptingDemuxerStream. 54 // Note: The caller owns selected Decoder and DecryptingDemuxerStream.
54 // The caller should call DecryptingDemuxerStream::Reset() before 55 // The caller should call DecryptingDemuxerStream::Reset() before
55 // calling Decoder::Reset() to release any pending decryption or read. 56 // calling Decoder::Reset() to release any pending decryption or read.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 // Could be the |stream| passed in SelectDecoder, or |decrypted_stream_| when 110 // Could be the |stream| passed in SelectDecoder, or |decrypted_stream_| when
110 // a DecryptingDemuxerStream is selected. 111 // a DecryptingDemuxerStream is selected.
111 DemuxerStream* input_stream_; 112 DemuxerStream* input_stream_;
112 113
113 CdmContext* cdm_context_; 114 CdmContext* cdm_context_;
114 std::string blacklisted_decoder_; 115 std::string blacklisted_decoder_;
115 SelectDecoderCB select_decoder_cb_; 116 SelectDecoderCB select_decoder_cb_;
116 typename Decoder::OutputCB output_cb_; 117 typename Decoder::OutputCB output_cb_;
117 base::Closure waiting_for_decryption_key_cb_; 118 base::Closure waiting_for_decryption_key_cb_;
118 119
119 ScopedVector<Decoder> decoders_; 120 std::vector<std::unique_ptr<Decoder>> decoders_;
120 121
121 std::unique_ptr<Decoder> decoder_; 122 std::unique_ptr<Decoder> decoder_;
122 std::unique_ptr<DecryptingDemuxerStream> decrypted_stream_; 123 std::unique_ptr<DecryptingDemuxerStream> decrypted_stream_;
123 124
124 // Config of the |input_stream| used to initialize decoders. 125 // Config of the |input_stream| used to initialize decoders.
125 DecoderConfig config_; 126 DecoderConfig config_;
126 127
127 // NOTE: Weak pointers must be invalidated before all other member variables. 128 // NOTE: Weak pointers must be invalidated before all other member variables.
128 base::WeakPtrFactory<DecoderSelector> weak_ptr_factory_; 129 base::WeakPtrFactory<DecoderSelector> weak_ptr_factory_;
129 130
130 DISALLOW_IMPLICIT_CONSTRUCTORS(DecoderSelector); 131 DISALLOW_IMPLICIT_CONSTRUCTORS(DecoderSelector);
131 }; 132 };
132 133
133 typedef DecoderSelector<DemuxerStream::VIDEO> VideoDecoderSelector; 134 typedef DecoderSelector<DemuxerStream::VIDEO> VideoDecoderSelector;
134 typedef DecoderSelector<DemuxerStream::AUDIO> AudioDecoderSelector; 135 typedef DecoderSelector<DemuxerStream::AUDIO> AudioDecoderSelector;
135 136
136 } // namespace media 137 } // namespace media
137 138
138 #endif // MEDIA_FILTERS_DECODER_SELECTOR_H_ 139 #endif // MEDIA_FILTERS_DECODER_SELECTOR_H_
OLDNEW
« no previous file with comments | « media/filters/audio_decoder_selector_unittest.cc ('k') | media/filters/decoder_selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698