media/mojo/clients/mojo_decoder_factory.h - Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/clients/mojo_decoder_factory.h

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)

Patch Set: Address xhwang's comments and delete some useless includes Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mojo/clients/mojo_decoder_factory.h

diff --git a/media/mojo/clients/mojo_decoder_factory.h b/media/mojo/clients/mojo_decoder_factory.h

index c808dbc4565091e9e68fe79642011ccf6ce100fa..7cb0101d1a631b9e4c3f8fc975f688044e68c60a 100644

--- a/media/mojo/clients/mojo_decoder_factory.h

+++ b/media/mojo/clients/mojo_decoder_factory.h

@@ -19,12 +19,12 @@ class MojoDecoderFactory : public DecoderFactory {

void CreateAudioDecoders(

scoped_refptr<base::SingleThreadTaskRunner> task_runner,

- ScopedVector<AudioDecoder>* audio_decoders) final;

+ std::vector<std::unique_ptr<AudioDecoder>>* audio_decoders) final;

void CreateVideoDecoders(

scoped_refptr<base::SingleThreadTaskRunner> task_runner,

GpuVideoAcceleratorFactories* gpu_factories,

- ScopedVector<VideoDecoder>* video_decoders) final;

+ std::vector<std::unique_ptr<VideoDecoder>>* video_decoders) final;

private:

service_manager::mojom::InterfaceProvider* interface_provider_;