Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2869873002: supersize: Sort diffs by default (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Sort diffs by default Prior to 9c9cc15, Print() would sort. However, now that it doesn't (so that indices are accurate), it's helpful to have Diff() sort by default. BUG=681694 Review-Url: https://codereview.chromium.org/2869873002 Cr-Commit-Position: refs/heads/master@{#470315} Committed: https://chromium.googlesource.com/chromium/src/+/b0ec883fdeea4c3b2b13900650c744d22e0b0f22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -105 lines) Patch
M tools/binary_size/libsupersize/console.py View 1 chunk +10 lines, -4 lines 0 comments Download
M tools/binary_size/libsupersize/diff.py View 1 chunk +2 lines, -9 lines 0 comments Download
M tools/binary_size/libsupersize/integration_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_Basic.golden View 1 chunk +92 lines, -92 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
agrieve
On 2017/05/08 17:24:52, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🐟
3 years, 7 months ago (2017-05-08 17:25:06 UTC) #3
estevenson
lgtm
3 years, 7 months ago (2017-05-08 17:33:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869873002/1
3 years, 7 months ago (2017-05-08 20:30:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/406000)
3 years, 7 months ago (2017-05-08 20:35:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869873002/1
3 years, 7 months ago (2017-05-09 13:51:05 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 14:00:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b0ec883fdeea4c3b2b13900650c7...

Powered by Google App Engine
This is Rietveld 408576698