supersize: Add symbol.template_name, and strip <>s from symbol.name

supersize: Add symbol.template_name, and strip <>s from symbol.name

Details:
 * full_name, template_name, name are now always set (full_name used to
   be None when same as name)
 * full_name (rather than name) is now set by linker_map_parser.
 * Adds: WhereIsTemplate() and WhereTemplateNameMatches()
 * Rename Cluster() -> Clustered() (to match tense of other methods).
 * Rename GroupBy*() -> GroupedBy*() (to match tense of other methods).
 * Fixes a bug in Cluster(), as shown by test goldens. I can't figure
   out what changed though!

Running a query of "WhereIsTemplate()" on libchrome.so shows that
templates comprise 4.97mb of 35.6mb. (14%)

The canned_query of "TemplatesByName" shows:
Top five templates:
0)     188057 (3.5%)  *@Group      188057  base::internal::Invoker::Run (count=5954)
1)     352433 (6.5%)  *@Group      164376  color_xform_RGBA (count=101)
2)     508259 (9.4%)  *@Group      155825  std::__ndk1::vector::__push_back_slow_path (count=1769)
3)     637251 (11.8%) *@Group      128992  std::__ndk1::__sort (count=170)
4)     728739 (13.5%) *@Group      91488   std::__ndk1::__tree::__insert_unique (count=641)

Top templates by namespace:
0)    1543846 (28.6%) *@Group      1543846 std (count=15883)
1)    2099482 (38.9%) *@Group      555636  WTF (count=7275)
2)    2640109 (48.9%) *@Group      540627  blink (count=17540)
3)    3150899 (58.4%) *@Group      510789  v8 (count=3293)
4)    3599574 (66.7%) *@Group      448674  base (count=20460)
5)    3957713 (73.4%) *@Group      358138  mojo (count=2795)
6)    4268254 (79.1%) *@Group      310541  IPC (count=6995)

Top collection classes:
1)     825057 (15.3%) *@Group      395878  std::__ndk1::vector (count=3327)
2)    1050592 (19.5%) *@Group      225534  std::__ndk1::__tree (count=3548)
3)    1275208 (23.6%) *@Group      224616  WTF::HashTable (count=2423)
6)    1873846 (34.7%) *@Group      193488  WTF::Vector (count=2461)
8)    2173194 (40.3%) *@Group      134972  std::__ndk1::deque (count=507)
10)   2386316 (44.2%) *@Group      103163  std::__ndk1::__hash_table (count=2019)

BUG=681694
Review-Url: https://codereview.chromium.org/2870743003
Cr-Commit-Position: refs/heads/master@{#470566}
Committed: https://chromium.googlesource.com/chromium/src/+/1f8fe2383c7805bb0385c118b19a8efe008ec741

[agrieve, 2017-05-09 15:54:49]

Description was changed from

==========
supersize: Add symbol.template_name, and strip <>s from symbol.name

Details:
 * full_name, template_name, name are now always set (full_name used to
   be None when same as name)
 * full_name (rather than name) is now set by linker_map_parser.
 * Adds: WhereIsTemplate() and WhereTemplateNameMatches()
 * Rename Cluster() -> Clustered() (to match tense of other methods).
 * Fixes a bug in Cluster(), as shown by test goldens. I can't figure
   out what changed though!

Running a query of "WhereIsTemplate()" on libchrome.so shows that
templates comprise 4.97mb of 35.6mb. (14%)

BUG=681694
==========

to

==========
supersize: Add symbol.template_name, and strip <>s from symbol.name

Details:
 * full_name, template_name, name are now always set (full_name used to
   be None when same as name)
 * full_name (rather than name) is now set by linker_map_parser.
 * Adds: WhereIsTemplate() and WhereTemplateNameMatches()
 * Rename Cluster() -> Clustered() (to match tense of other methods).
 * Rename GroupBy*() -> GroupedBy*() (to match tense of other methods).
 * Fixes a bug in Cluster(), as shown by test goldens. I can't figure
   out what changed though!

Running a query of "WhereIsTemplate()" on libchrome.so shows that
templates comprise 4.97mb of 35.6mb. (14%)

The canned_query of "TemplatesByName" shows:
Top five templates:
0)     188057 (3.5%)  *@Group      188057  base::internal::Invoker::Run
(count=5954)
1)     352433 (6.5%)  *@Group      164376  color_xform_RGBA (count=101)
2)     508259 (9.4%)  *@Group      155825 
std::__ndk1::vector::__push_back_slow_path (count=1769)
3)     637251 (11.8%) *@Group      128992  std::__ndk1::__sort (count=170)
4)     728739 (13.5%) *@Group      91488   std::__ndk1::__tree::__insert_unique
(count=641)

Top templates by namespace:
0)    1543846 (28.6%) *@Group      1543846 std (count=15883)
1)    2099482 (38.9%) *@Group      555636  WTF (count=7275)
2)    2640109 (48.9%) *@Group      540627  blink (count=17540)
3)    3150899 (58.4%) *@Group      510789  v8 (count=3293)
4)    3599574 (66.7%) *@Group      448674  base (count=20460)
5)    3957713 (73.4%) *@Group      358138  mojo (count=2795)
6)    4268254 (79.1%) *@Group      310541  IPC (count=6995)

Top collection classes:
1)     825057 (15.3%) *@Group      395878  std::__ndk1::vector (count=3327)
2)    1050592 (19.5%) *@Group      225534  std::__ndk1::__tree (count=3548)
3)    1275208 (23.6%) *@Group      224616  WTF::HashTable (count=2423)
6)    1873846 (34.7%) *@Group      193488  WTF::Vector (count=2461)
8)    2173194 (40.3%) *@Group      134972  std::__ndk1::deque (count=507)
10)   2386316 (44.2%) *@Group      103163  std::__ndk1::__hash_table
(count=2019)

BUG=681694
==========

[agrieve, 2017-05-09 15:54:49]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-05-09 15:54:58]

On 2017/05/09 15:54:49, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🐛

[estevenson, 2017-05-09 22:15:12]

lgtm

https://codereview.chromium.org/2870743003/diff/20001/tools/binary_size/libsu...
File tools/binary_size/libsupersize/cluster_symbols.py (right):

https://codereview.chromium.org/2870743003/diff/20001/tools/binary_size/libsu...
tools/binary_size/libsupersize/cluster_symbols.py:90: index_and_name_tups = []
I find this function hard to grok, basically had to try to figure out what it
does all over again. Might be worth it to add some more detailed comments, your
call.

https://codereview.chromium.org/2870743003/diff/20001/tools/binary_size/libsu...
File tools/binary_size/libsupersize/models.py (right):

https://codereview.chromium.org/2870743003/diff/20001/tools/binary_size/libsu...
tools/binary_size/libsupersize/models.py:72: 'raw_symbols',
nit: could update the docs above.

[agrieve, 2017-05-10 00:51:38]

https://codereview.chromium.org/2870743003/diff/20001/tools/binary_size/libsu...
File tools/binary_size/libsupersize/cluster_symbols.py (right):

https://codereview.chromium.org/2870743003/diff/20001/tools/binary_size/libsu...
tools/binary_size/libsupersize/cluster_symbols.py:90: index_and_name_tups = []
On 2017/05/09 22:15:12, estevenson wrote:
> I find this function hard to grok, basically had to try to figure out what it
> does all over again. Might be worth it to add some more detailed comments,
your
> call.

likewise. For now I've just added a TODO comment to the top saying that it's not
actually even conceptually different from GroupedBy(). Maybe could just be built
ontop of that?

https://codereview.chromium.org/2870743003/diff/20001/tools/binary_size/libsu...
File tools/binary_size/libsupersize/models.py (right):

https://codereview.chromium.org/2870743003/diff/20001/tools/binary_size/libsu...
tools/binary_size/libsupersize/models.py:72: 'raw_symbols',
On 2017/05/09 22:15:12, estevenson wrote:
> nit: could update the docs above.

Done.

[agrieve, 2017-05-10 01:05:13]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:06:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:10:27]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[agrieve, 2017-05-10 14:30:34]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-05-10 14:30:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2870743003/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2017-05-10 14:31:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 14:37:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494426634936200,
"parent_rev": "8fdcb922fcb704745bcd2b4376605582bea0f54d", "commit_rev":
"1f8fe2383c7805bb0385c118b19a8efe008ec741"}

[commit-bot: I haz the power, 2017-05-10 14:37:48]

Description was changed from

==========
supersize: Add symbol.template_name, and strip <>s from symbol.name

Details:
 * full_name, template_name, name are now always set (full_name used to
   be None when same as name)
 * full_name (rather than name) is now set by linker_map_parser.
 * Adds: WhereIsTemplate() and WhereTemplateNameMatches()
 * Rename Cluster() -> Clustered() (to match tense of other methods).
 * Rename GroupBy*() -> GroupedBy*() (to match tense of other methods).
 * Fixes a bug in Cluster(), as shown by test goldens. I can't figure
   out what changed though!

Running a query of "WhereIsTemplate()" on libchrome.so shows that
templates comprise 4.97mb of 35.6mb. (14%)

The canned_query of "TemplatesByName" shows:
Top five templates:
0)     188057 (3.5%)  *@Group      188057  base::internal::Invoker::Run
(count=5954)
1)     352433 (6.5%)  *@Group      164376  color_xform_RGBA (count=101)
2)     508259 (9.4%)  *@Group      155825 
std::__ndk1::vector::__push_back_slow_path (count=1769)
3)     637251 (11.8%) *@Group      128992  std::__ndk1::__sort (count=170)
4)     728739 (13.5%) *@Group      91488   std::__ndk1::__tree::__insert_unique
(count=641)

Top templates by namespace:
0)    1543846 (28.6%) *@Group      1543846 std (count=15883)
1)    2099482 (38.9%) *@Group      555636  WTF (count=7275)
2)    2640109 (48.9%) *@Group      540627  blink (count=17540)
3)    3150899 (58.4%) *@Group      510789  v8 (count=3293)
4)    3599574 (66.7%) *@Group      448674  base (count=20460)
5)    3957713 (73.4%) *@Group      358138  mojo (count=2795)
6)    4268254 (79.1%) *@Group      310541  IPC (count=6995)

Top collection classes:
1)     825057 (15.3%) *@Group      395878  std::__ndk1::vector (count=3327)
2)    1050592 (19.5%) *@Group      225534  std::__ndk1::__tree (count=3548)
3)    1275208 (23.6%) *@Group      224616  WTF::HashTable (count=2423)
6)    1873846 (34.7%) *@Group      193488  WTF::Vector (count=2461)
8)    2173194 (40.3%) *@Group      134972  std::__ndk1::deque (count=507)
10)   2386316 (44.2%) *@Group      103163  std::__ndk1::__hash_table
(count=2019)

BUG=681694
==========

to

==========
supersize: Add symbol.template_name, and strip <>s from symbol.name

Details:
 * full_name, template_name, name are now always set (full_name used to
   be None when same as name)
 * full_name (rather than name) is now set by linker_map_parser.
 * Adds: WhereIsTemplate() and WhereTemplateNameMatches()
 * Rename Cluster() -> Clustered() (to match tense of other methods).
 * Rename GroupBy*() -> GroupedBy*() (to match tense of other methods).
 * Fixes a bug in Cluster(), as shown by test goldens. I can't figure
   out what changed though!

Running a query of "WhereIsTemplate()" on libchrome.so shows that
templates comprise 4.97mb of 35.6mb. (14%)

The canned_query of "TemplatesByName" shows:
Top five templates:
0)     188057 (3.5%)  *@Group      188057  base::internal::Invoker::Run
(count=5954)
1)     352433 (6.5%)  *@Group      164376  color_xform_RGBA (count=101)
2)     508259 (9.4%)  *@Group      155825 
std::__ndk1::vector::__push_back_slow_path (count=1769)
3)     637251 (11.8%) *@Group      128992  std::__ndk1::__sort (count=170)
4)     728739 (13.5%) *@Group      91488   std::__ndk1::__tree::__insert_unique
(count=641)

Top templates by namespace:
0)    1543846 (28.6%) *@Group      1543846 std (count=15883)
1)    2099482 (38.9%) *@Group      555636  WTF (count=7275)
2)    2640109 (48.9%) *@Group      540627  blink (count=17540)
3)    3150899 (58.4%) *@Group      510789  v8 (count=3293)
4)    3599574 (66.7%) *@Group      448674  base (count=20460)
5)    3957713 (73.4%) *@Group      358138  mojo (count=2795)
6)    4268254 (79.1%) *@Group      310541  IPC (count=6995)

Top collection classes:
1)     825057 (15.3%) *@Group      395878  std::__ndk1::vector (count=3327)
2)    1050592 (19.5%) *@Group      225534  std::__ndk1::__tree (count=3548)
3)    1275208 (23.6%) *@Group      224616  WTF::HashTable (count=2423)
6)    1873846 (34.7%) *@Group      193488  WTF::Vector (count=2461)
8)    2173194 (40.3%) *@Group      134972  std::__ndk1::deque (count=507)
10)   2386316 (44.2%) *@Group      103163  std::__ndk1::__hash_table
(count=2019)

BUG=681694

Review-Url: https://codereview.chromium.org/2870743003
Cr-Commit-Position: refs/heads/master@{#470566}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f8fe2383c7805bb0385c118b19a...
==========

[commit-bot: I haz the power, 2017-05-10 14:37:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f8fe2383c7805bb0385c118b19a...